Repository navigation
Settings: group sidebar navigation by taxonomy - #13039
Closed
teamleaderleo wants to merge 1 commit into
Closed
teamleaderleo wants to merge 1 commit into
teamleaderleo wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe settings package now defines eight localized taxonomy groups, renders grouped sidebar entries outside search, preserves existing section identities, and validates coverage, ordering, search identity, and localized titles. ChangesSettings taxonomy
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant SettingsSearchIndex
participant SettingsWindowScene
participant SettingsTaxonomyGroup
SettingsSearchIndex->>SettingsWindowScene: provide section entries
SettingsWindowScene->>SettingsTaxonomyGroup: request taxonomy order
SettingsTaxonomyGroup-->>SettingsWindowScene: return grouped section IDs
SettingsWindowScene->>SettingsWindowScene: render grouped sidebar rows
SettingsSearchIndex->>SettingsWindowScene: provide flat results for active search
Suggested reviewers: 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 4 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
teamleaderleo
force-pushed
the
lane-b-settings-taxonomy
branch
from
September 19, 2026 18:09
eb808f4 to
a7c910a
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
teamleaderleo
force-pushed
the
lane-b-settings-taxonomy
branch
from
September 19, 2026 18:12
1de6be3 to
43c6eb6
Compare
teamleaderleo
force-pushed
the
lane-b-settings-taxonomy
branch
from
September 19, 2026 18:13
a6342de to
7c5e1ff
Compare
teamleaderleo
commented
Sep 19, 2026
teamleaderleo
left a comment
teamleaderleo
left a comment
Collaborator
Author
There was a problem hiding this comment.
Manual pass on current head 7c5e1ffa6a7cff5393763b585821b66585662fe3 because the automated review was partly rate-limited.
I checked the taxonomy against search/deep-link behavior specifically:
- whitespace-only search still counts as browse mode;
- clearing search resets the selected row to the current section, matching the existing behavior;
- active search stays flat and keeps the original entry IDs/anchors;
- external navigation still preserves an active setting hit when it targets the same parent section;
- runtime-hidden Cloud entries are filtered before taxonomy grouping.
I found no additional issue in those navigation seams.
Collaborator
Author
Local UI verification — September 19, 2026Tested
Observation for follow-up: searching Built as an isolated tagged Debug app. The only local overlay was the two build-script files from #12973 to enable ScreenshotsGrouped Settings
Lower groups and Keyboard Shortcuts
Search result navigating to the setting
|
Collaborator
Author
|
Replaced by #13222: same commits, head branch moved into the org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer summary
Groups Settings navigation by the way people look for a setting, with clearer labels and descriptions.
What changed
SettingsSectionID, section title, setting ID, stored value, default, persistence path, and feature implementation unchangedNavigation compatibility
The taxonomy is presentation-only. Existing leaf destinations still use the same
section:<rawValue>IDs andcmux.settings.navigatetargets, so restored selection,cmux settings open <target>, search hits, and deep row anchors continue through the existing paths.Tests
SettingsTaxonomyTestsverifies every existing navigation leaf appears exactly once in the taxonomyCoordinates Lane B from teamleaderleo/Tact#79.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Groups the Settings sidebar into eight browse categories so the default view is easier to scan, implementing Lane B of teamleaderleo/Tact#79. Search stays flat and relevance-ranked while a query is active, preserving existing search hit IDs, row anchors, and navigation targets.
Compatibility
SettingsSectionIDvalues, section titles, setting IDs, defaults, and persistence paths are unchanged.CmuxSettingsUIresource catalog; the package now bundles itsResourcesdirectory.Tests
SettingsTaxonomyTestsverifies every leaf appears exactly once, group membership/order, empty-query search IDs, and localized group titles.Written for commit 7c5e1ff. Summary will update on new commits.
Summary by CodeRabbit