ci: run CLI smoke checks before app-host fan-out

[teamleaderleo]

The CLI version/memory and help-contract checks currently run late in app-host shard 6. In CI run 35492827219, a seven-second CLI step failed 18m42s after compilation finished, while expensive app tests were already running.

Move those existing probes into macOS compile admission after framework staging and before product packaging/upload. A missing CLI or failed probe now prevents app-host shard and runtime admission. Remove the old invocations so the checks run once. This changes failure timing, not which CLI contracts must pass.

Validation: executable workflow-step regression covers the exact current-build binary path (including spaces), missing binary, each probe failing, and both passing. The regression failed before the workflow change and passes afterward. python3 tests/test_ci_change_areas.py, actionlint .github/workflows/ci.yml, and git diff --check pass. Actual compiled macOS binary execution awaits hosted CI; no full local app build or manual CI rerun was started.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Moves the CLI version/memory and help-contract smoke checks into macOS compile admission so they run before app-host fan-out. This changes failure timing, not which CLI contracts must pass.

• The checks previously ran in app-host shard 6, after expensive app tests had already started.
• A missing CLI binary or failed probe now blocks app-host shard and runtime admission.
• Removes the old invocations so each check runs once.
• Adds a regression covering a missing binary, each probe failing, both passing, and the checks running before packaging/upload.

^{Written for commit 5a6322e. Summary will update on new commits.}

[coderabbitai]

Warning

Review limit reached

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 013b0023-b6ca-45de-8a90-121ebbfdc541

📥 Commits

Reviewing files that changed from the base of the PR and between 5517d3d and 5a6322e.

📒 Files selected for processing (2)

• .github/workflows/ci.yml
• tests/test_ci_change_areas.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge; the previously missing workflow-ordering regression is now present and no new actionable issue was identified.

Summary

Moves existing CLI version/memory and help-contract probes into macOS compile admission so failures occur before packaging and downstream app-host/runtime fan-out.

• Uses the CLI binary from the current compile-admission build.
• Preserves immediate failure for a missing binary or failed probe.
• Removes the later duplicate probe invocations.
• Adds regression coverage for probe behavior and workflow ordering.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    A[macOS compile admission] --> B[Stage package frameworks]
    B --> C[Run CLI smoke checks]
    C -->|Success| D[Package app-host product]
    C -->|Failure| E[Stop admission]
    D --> F[Upload product]
    F --> G[App-host and runtime fan-out]

Loading

_{Reviews (2) · Last reviewed commit: "test: guard early CLI smoke ordering"}