test: stop the XCTest import warning flood

[teamleaderleo]

Summary

Three cmuxTests files import XCTest with @_implementationOnly while the rest of the target use ordinary imports. The notification integration job in run 35494917252 emitted 122,136 inconsistent-XCTest-import warnings and about 90 MB of total logs.

Use ordinary XCTest imports in all three files. Test bodies and assertions are unchanged. This removes the import mismatch at its source; the compile-time saving has not been measured.

Testing

• Reproduced the same diagnostic with a two-file XCTest module using mixed import modes on Apple Swift 6.2.4.
• The identical compiler reproduction with consistent imports passes swiftc -typecheck -warnings-as-errors with no output.
• git diff --check passes.
• Full cmuxTests compilation is delegated to macOS compile admission in this PR's CI. No app runtime code changed, so no app reload or UI demo is needed.

---

Summary by cubic

Replaces @_implementationOnly import XCTest with a normal import XCTest in the three test files that still used the private import. This removes the source of the 122,136 inconsistent-XCTest-import warnings (about 90 MB of logs) from the notification integration CI job. Test bodies and assertions are unchanged, and no runtime code changed.

^{Written for commit 1631b47. Summary will update on new commits.}

Summary by CodeRabbit

• Tests
  • Updated test module imports to use standard XCTest access, improving compatibility and test integration.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e23026f7-5b02-4e65-a786-383581bb584e

📥 Commits

Reviewing files that changed from the base of the PR and between 02cd032 and 1631b47.

📒 Files selected for processing (3)

• cmuxTests/AutomationProcessSessionTests.swift
• cmuxTests/KimiResumeReviewRegressionTests.swift
• cmuxTests/WorkspaceUnitTests.swift

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

Three test files now import XCTest normally instead of using @_implementationOnly.

Changes

Test import visibility

Layer / File(s)	Summary
Regular XCTest imports cmuxTests/AutomationProcessSessionTests.swift, cmuxTests/KimiResumeReviewRegressionTests.swift, cmuxTests/WorkspaceUnitTests.swift	The three test files now use standard XCTest imports without @_implementationOnly.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: austinywang

🚥 Pre-merge checks | ✅ 25

✅ Passed checks (25 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description clearly explains the import changes, the reason for them, and the testing performed. It also explains why no demo video is needed. The review trigger and checklist sections are omitted…
Title check	✅ Passed	The title clearly identifies the main change: stopping the XCTest import warning flood.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input	✅ Passed	PASS — The authoritative PR diff changes only three cmuxTests files, and each change replaces @_implementationOnly import XCTest with import XCTest. No Cloud terminal creation, persistent `cmux-…
Cmux Swift Actor Isolation	✅ Passed	PASS: The authoritative diff changes only three files under cmuxTests/. Each change replaces @_implementationOnly import XCTest with import XCTest; test bodies and production Swift files are unc…
Cmux Swift Blocking Runtime	✅ Passed	PASS. The authoritative diff changes only three files under cmuxTests, and each added line is only import XCTest. No semaphore, wait, sleep, delayed dispatch, polling, main-queue sync, or lock was…
Cmux Browser Automation Off-Main	✅ Passed	PASS. The authoritative diff changes only three XCTest import lines in cmuxTests files. It does not add or move any browser.* socket command, WebKit wait, main-actor route, socket-worker route, browse…
Cmux Expensive Synchronous Load	✅ Passed	The authoritative diff changes only three XCTest import lines in cmuxTests files, replacing @_implementationOnly import XCTest with import XCTest. Test bodies and all production code remain unch…
Cmux Cache Substitution Correctness	✅ Passed	PASS: The reviewed range changes only three test files, and each change is a one-line replacement of @_implementationOnly import XCTest with import XCTest. No production Swift, TypeScript, or Java…
Cmux No Hacky Sleeps	✅ Passed	PASS. The authoritative diff changes only three Swift files under cmuxTests, and each change only replaces @_implementationOnly import XCTest with import XCTest. The custom check applies to prod…
Cmux Algorithmic Complexity	✅ Passed	PASS. The authoritative diff changes only three files under cmuxTests, with one XCTest import replacement per file. No production code or collection algorithm changed. The policy explicitly passes t…
Cmux Swift Concurrency	✅ Passed	PASS. The pull request changes only three import lines: each @_implementationOnly import XCTest becomes import XCTest. The changed-line filter shows no new Dispatch, Combine, completion-handler, o…
Cmux Swift @Concurrent	✅ Passed	PASS: The PR changes only three XCTest import declarations from @_implementationOnly import XCTest to import XCTest. The diff introduces no @concurrent, nonisolated async, actor-isolation, o…
Cmux Swift Package Boundaries	✅ Passed	PASS. The authoritative diff changes only three files under cmuxTests. Each change replaces @_implementationOnly import XCTest with import XCTest; test declarations and bodies are unchanged. The…
Cmux Swiftpm Lockfiles	✅ Passed	PASS. The pull request changes only three cmuxTests Swift files. Each change replaces @_implementationOnly import XCTest with import XCTest. The diff contains no Package.swift, `Package.resolved…
Cmux Swift Logging	✅ Passed	PASS: The pull request changes only three XCTest import declarations, from @_implementationOnly import XCTest to import XCTest. No print, debugPrint, dump, NSLog, Logger, file logging, o…
Cmux User-Facing Error Privacy	✅ Passed	The pull request changes only three test files. Each change replaces @_implementationOnly import XCTest with import XCTest; no user-facing errors, alerts, command output, API bodies, or recovery t…
Cmux Full Internationalization	✅ Passed	PASS. The authoritative diff changes only three files under cmuxTests, and each change is only @_implementationOnly import XCTest to import XCTest. It adds no production user-facing text, locali…
Cmux Swiftui State Layout	✅ Passed	The pull request changes only three XCTest import lines. The authoritative diff contains no new or modified SwiftUI state, GeometryReader layout, lazy/list row store reference, or render-time mutation…
Cmux Architecture Rethink	✅ Passed	PASS. The scoped diff changes only three XCTest import declarations in test files. After replacing the old import spelling with the new spelling, each file is identical. The patch adds no timing, bl…
Cmux Swift Auxiliary Window Close Shortcuts	✅ Passed	PASS. The review-scoped diff changes only three cmuxTests XCTest import lines. It adds or materially changes no NSWindow, NSPanel, NSWindowController, SwiftUI Window, or WindowGroup code. …
Cmux Source Artifacts	✅ Passed	The pull request changes only three tracked Swift test source files: cmuxTests/AutomationProcessSessionTests.swift, cmuxTests/KimiResumeReviewRegressionTests.swift, and `cmuxTests/WorkspaceUnitTes…
Cmux No Test Or Debug Seam In Production Source	✅ Passed	PASS: The reviewed diff changes only three files under cmuxTests/, outside the custom check scope of Swift files under **/Sources/** and not under **/Tests/**. Each change only replaces `@_imple…

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge because it only standardizes XCTest imports in test files.

Summary

This PR standardizes XCTest imports in three test files to eliminate inconsistent-import compiler warnings.

• Replaces @_implementationOnly import XCTest with import XCTest.
• Leaves test bodies, assertions, and production code unchanged.

_{Reviews (1) · Last reviewed commit: "test: use consistent XCTest imports to s..."}