Repository navigation
ci: run slow and history-dependent guards in parallel jobs - #13097
Conversation
workflow-guard-tests took about 390 s on the critical path to every macOS job. 104 s of that was a full-history checkout that only the SwiftPM lockfile policy needs, and four steps accounted for another 170 s. The lockfile policy moves to workflow-guard-history, the only guard job that still fetches history. The cmux-tui commit resolution and profiling script guards move to workflow-guard-cli-scripts, and the sidebar lazy-layout and DispatchWorkItem lints move to workflow-guard-source-lints. Each new job sets up the same Python 3.9 and pip packages the steps ran under before. linux-preflight requires all four jobs to succeed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
e3f22bd ci: run slow and history-dependent guards beside workflow-guard-tests (manaflow-ai#13097) 974c2c4 Normalize Cloud tree machine icon spacing (manaflow-ai#13081) 10d13a6 test: align cloud rename parity with optimistic tree (manaflow-ai#13092) be7692c ci: start the agent notification lane only for the suites it runs (manaflow-ai#13067) 2bda736 ci: run web validation for the merge queue (manaflow-ai#13069) 39f1328 ci: cancel superseded pull request runs in three macOS workflows (manaflow-ai#13064) 80ee5dc ci: skip blocked internal TestFlight polls (manaflow-ai#13062) cbb3477 ci: stop routing workflow plumbing changes to macOS (manaflow-ai#13083) 22d913e Quiet cloud terminal creation tabs (manaflow-ai#12979)
Summary
workflow-guard-testssits on the critical path to every macOS job and took about 390 s (example). 104 s was afetch-depth: 0checkout. A shallow checkout of this repo takes 10 s, and only one step reads history: the SwiftPM lockfile policy, which diffs against the merge base. Four other steps took 170 s between them.workflow-guard-testsnow uses a shallow checkout and keeps every step except the ones below. Expected about 120 s.workflow-guard-historykeepsfetch-depth: 0and runs the SwiftPM lockfile policy. It is the only guard job that fetches history.workflow-guard-cli-scriptsruns the cmux-tui client commit resolution (60 s) and profiling script (33 s) guards.workflow-guard-source-lintsruns the sidebar lazy-layout guard (55 s) and the DispatchWorkItem lint (20 s) with its Bonsplit init.linux-preflightrequires success from all four, so macOS still starts only after every guard passes.ci-statuslists them too.The moved steps are unchanged. Each new job sets up Python 3.9 and the same pinned pip packages, because those steps ran after that setup before. No other guard script calls
gitagainst repo history (checked by grepping every script the job runs), and no test pins the moved steps to the old job.This is step 2 of #13095. This PR edits
tests/test_ci_change_areas.py, so the router runs every area for it.Testing
actionlint .github/workflows/ci.ymlpython3 tests/test_ci_change_areas.pyon Python 3.9 and 3.12. New cases:linux-preflightfails when any of the four guard jobs is failed, cancelled or skipped, and onlyworkflow-guard-historyfetches full history.tests/test_ci_reusable_workflow_permissions.py,tests/test_ci_app_host_home_isolation.py,tests/test_ios_testflight_pro_distribution.py,tests/test_ci_self_hosted_guard.sh, which all parse theworkflow-guard-testsjob.Issues
testsCI job (currently 21–25 min, gates every PR) #6134🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Splits the slow and history-dependent guard steps out of
workflow-guard-testsso macOS jobs no longer wait on one ~390s critical path.workflow-guard-testsnow uses a shallow checkout; only the newworkflow-guard-historyjob fetches full history.workflow-guard-cli-scriptsruns the cmux-tui client commit resolution and profiling script guards.workflow-guard-source-lintsruns the sidebar lazy-layout and DispatchWorkItem lints.linux-preflightandci-statusnow require all four guard jobs to succeed.test_ci_change_areas.pyto enforce the new job requirements and the history-fetching split.Written for commit 45165b0. Summary will update on new commits.