Repository navigation
Fix NIGHTLY passive update pill discovery - #12473
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 13, 2026
2aad772 Merge pull request manaflow-ai#12444 from manaflow-ai/issue-12437-machine-resource-metrics 7d9684d test: format localized resize menu expectations 4bcbe02 test: simplify machine menu assertions for Swift Testing 4bcdc92 Merge pull request manaflow-ai#12452 from manaflow-ai/issue-12449-cloud-terminal-colors 43b74b6 Merge pull request manaflow-ai#12447 from manaflow-ai/issue-12376-followup-cloud-tui-start 9c0cc34 fix: normalize the Dock terminal-link tab lookup key 5f2f3a8 fix: quote the resource snapshot adapter project path 8a9fc84 Merge remote-tracking branch 'origin/main' into issue-12449-cloud-terminal-colors 2b09913 Fix Iroh control-session termination during Mac switching (manaflow-ai#12324) 4c8e0b5 fix: address resource metrics review and CI findings 558859c test: keep the Hermes fixture within its process sandbox 3ea553d fix: clean up stale Cloud projections a4aef92 Merge remote-tracking branch 'origin/main' into issue-12376-followup-cloud-tui-start ebc3f02 Merge remote-tracking branch 'origin/main' into issue-12376-followup-cloud-tui-start 7bf465a fix: use the pinned Ghostty terminal-link action kind d594a7e test: expose lost resize resource confirmations faae269 Merge pull request manaflow-ai#12474 from manaflow-ai/issue-12357-cloud-terminal-navigation 187d741 Merge pull request manaflow-ai#12462 from manaflow-ai/issue-12458-cloud-sidebar-sync dad13a8 Merge origin/main into issue-12357-cloud-terminal-navigation 4160aa0 fix: preserve focused Cloud tab across pane moves 2e3d03c test: provide an isolated Hermes activation fixture e56599a Merge pull request manaflow-ai#12473 from manaflow-ai/issue-12467-nightly-update-pill a087656 fix: preserve user-owned Cloud titles during reconciliation 005c0d4 fix: satisfy Clippy for inherited agent hook formatters 51cf2bb fix(cloud): navigate nested terminals to owner workspace c58711e Merge remote-tracking branch 'origin/main' into issue-12376-followup-cloud-tui-start a9eaf34 Merge latest origin/main and keep actor-safe Cloud overlay init 527546e Merge remote-tracking branch 'origin/main' into issue-12449-cloud-terminal-colors 68b56b2 fix: preserve Swift actor-safe Cloud overlay initialization fc8b523 fix: keep one Cloud overlay default initializer e2eeb5f Merge latest main and preserve cloud initializer fix adae986 fix: finalize Cloud projection merge integration e1f7d2b Merge remote-tracking branch 'origin/main' into issue-12376-followup-cloud-tui-start 29e1411 test: reproduce passive update pill after sidebar mount 470e754 Construct cloud banner defaults on the main actor 9d89682 test: preserve application colors through resize and reattach a475d98 Merge remote-tracking branch 'origin/main' into issue-12376-followup-cloud-tui-start 3b22dad fix: retain Cloud attachment placement across retries e38fb3f Merge origin/main and preserve Cloud sidebar synchronization 3051015 Merge remote-tracking branch 'origin/main' into issue-12449-cloud-terminal-colors 6b2a525 Fix compiler warnings blocking merged branch CI c0fcb84 Merge origin/main and resolve resource metrics conflicts 00a26d0 test: avoid recursive Swift Testing macro expansion 812d510 fix: align Cloud screen ordering and terminal inventory names d708a6b Merge remote-tracking branch 'origin/main' into issue-12376-followup-cloud-tui-start b9d3c8e test(cloud): cover owner workspace terminal navigation 578b155 Merge remote-tracking branch 'origin/main' into issue-12376-followup-cloud-tui-start 3fe7bed fix: keep Cloud reconnect from recreating closed tab views 2634da9 test: repair optional Iroh coverage in the hosted gate 595d813 fix: negotiate color provenance without changing legacy streams fb71e15 fix: isolate Cloud overlay dismissal initialization 9553c71 fix: reconcile live Cloud workspace membership and native layout dd4c3a7 test: use a cancellable publication database deadline 267c42d fix: isolate reporter failures and coalesce samples atomically adec879 Merge remote-tracking branch 'origin/main' into issue-12376-followup-cloud-tui-start 0024d2e fix: preserve Cloud terminal creation workspace fb2e043 fix: preserve Cloud selection identity and pending name intent cac0a53 test: cover reporter setup failure and concurrent samples 9bedece fix: derive Cloud workspace opening and titles from accepted state 3b7c320 fix: import Cloud workspace surface kinds b983e64 test: reproduce Cloud sidebar layout and title divergence d4dfa3d test: align startup and network guards with current flows 057b587 fix: import Cloud surface kinds 7ce1f67 fix: restore scoped Cloud workspace destination defaults 848227f test: keep Cloud colors stable across repeated viewer updates 4c2611f docs: cover the cloud diagnostics socket method 85321a3 Merge remote-tracking branch 'origin/main' into issue-12437-machine-resource-metrics 0d0979e fix: restore workspace group destination fallback 72b921c Merge remote-tracking branch 'origin/main' into issue-12449-cloud-terminal-colors 0cd9987 Merge remote-tracking branch 'origin/main' into issue-12376-followup-cloud-tui-start f76013d fix: keep Cloud viewer themes separate from shared terminal defaults ef3b05f fix: wire Cloud creation files to their source groups 2a80274 fix: harden Cloud terminal creation recovery f7a183f fix: use scoped cloud workspace group defaults 8b430f2 test: reproduce Cloud viewer recoloring from shared defaults 2acaa47 Merge remote-tracking branch 'origin/main' into issue-12376-followup-cloud-tui-start 24d634a Merge main and preserve starred resource rows 9768d45 feat: collect cloud resource usage from awake guests 16ae857 Merge remote-tracking branch 'origin/main' into issue-12376-followup-cloud-tui-start 8a3008b fix: keep Cloud split panes visible while terminal creation recovers ba47476 test: require live usage from Freestyle machine stats c8e618d test: keep Cloud terminal creation panes explainable during link errors 334f7cd fix: keep full resource percentages visible in narrow rows b88e525 feat: give cloud machines prominent CPU RAM and disk readings 2ce6323 test: reserve cloud machine row space for resource metrics # Conflicts: # .github/workflows/cmux-tui.yml
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12467
The passive Sparkle update probe records availability in
UpdateStateModel, but the sidebar footer is inside anEquatablesidebar subtree that only carries the model reference. In-place passive mutations can therefore be skipped until an unrelated redraw. This PR adds a delayed passive-callback UI regression that runs after the sidebar mounts; the first commit intentionally fails on the current implementation so CI proves the repro.Validation so far:
git diff --check.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes passive Sparkle update discovery so a detected update that arrives after the sidebar mounts still shows in the update pill. Adds a regression UI test that simulates a delayed passive update after the sidebar mounts.
Written for commit 29e1411. Summary will update on new commits.