Repository navigation
Revert "feat(browser): Chromium browser panes via in-process CEF, with extensions" - #11966
Merged
austinywang merged 1 commit intoSep 4, 2026
Merged
Conversation
…h extens…" This reverts commit 4b3951c.
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Contributor
|
Too many files changed for review (472 files, 100 file limit). Bypass the limit by tagging |
|
Important Review skippedToo many files! This PR contains 471 files, which is 171 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (471)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 4, 2026
e83b832 Revert "feat(browser): Chromium browser panes via in-process CEF, with extens…" (manaflow-ai#11966) f838159 Clarify Cloud VM capacity is shared (manaflow-ai#11897)
This was referenced Sep 5, 2026
austinywang
added a commit
that referenced
this pull request
Sep 5, 2026
The same squash merge (19f51d5, #11789) re-added three cmux.xcodeproj entries for SystemDefaultBrowserDetector.swift: the PBXBuildFile, the PBXFileReference, and the cmux target's Sources entry. The file itself was deleted by the CEF revert (#11966, e83b832), which also removed those entries on main; the VPN branch's merge of that revert kept them. The reference sits in no group, so Xcode resolves it against the project root and the app target fails with: error: Build input file cannot be found: '.../SystemDefaultBrowserDetector.swift' The nightly never reached this error because cmux-cli failed first. Remove the three entries, matching the revert. No other file reference in the project is orphaned or missing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA5g4LcJ3QYAARgJjKCXvG
austinywang
added a commit
that referenced
this pull request
Sep 5, 2026
…11999) * Restore CMUXCLI.vmAttachTransportUnsupportedCode so cmux-cli compiles Every "Nightly macOS build" run on main since 19f51d5 fails in build-nightly-app with: CLI/cmux.swift:13798: error: type 'CMUXCLI' has no member 'vmAttachTransportUnsupportedCode' Two independent changes crossed. The Cloud VPN branch (#11789, commit c9272d3) removed the cmux-tui fallback helpers from CLI/CMUXCLI+VMTui.swift, including this constant, because every Cloud route now goes through the WireGuard hub. Five hours later main gained a new use of the same constant in shouldFallbackFromForcedSSH (c8098d7). The branch's later merges of main combined both sides without a textual conflict, and the squash merge landed the dangling reference on main. PR CI never compiled Swift for #11789: web-typecheck failed, so linux-preflight failed and every macOS job was skipped, while the no-op "CI status fallback" workflow satisfied the required ci-status check and auto-merge went ahead. Restore the constant in CLI/CMUXCLI+VMTui.swift. The control plane still answers 409 vm_attach_transport_unsupported (web/services/vms/routeHelpers.ts), and VMSSHCommandTests.testVMSSHAliasUsesCmuxRemoteWhenProviderSSHIsUnmanaged covers the forced-SSH fallback that reads it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA5g4LcJ3QYAARgJjKCXvG * Drop stale SystemDefaultBrowserDetector.swift project entries The same squash merge (19f51d5, #11789) re-added three cmux.xcodeproj entries for SystemDefaultBrowserDetector.swift: the PBXBuildFile, the PBXFileReference, and the cmux target's Sources entry. The file itself was deleted by the CEF revert (#11966, e83b832), which also removed those entries on main; the VPN branch's merge of that revert kept them. The reference sits in no group, so Xcode resolves it against the project root and the app target fails with: error: Build input file cannot be found: '.../SystemDefaultBrowserDetector.swift' The nightly never reached this error because cmux-cli failed first. Remove the three entries, matching the revert. No other file reference in the project is orphaned or missing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA5g4LcJ3QYAARgJjKCXvG * Re-merge CmuxTuiSurfaceProviders.swift: keep main's state sync, apply the private-link port scan The VPN branch's merge of main (0ecbf91, "Merge origin/main into cloud tunnel PR branch") resolved seven conflict hunks in this file by taking the branch side, which: - left a `guard catalog.replaceResources(` with no `else` and Void `return`s inside `refresh(force:) -> Bool` (the app target did not parse; the nightly never got this far because cmux-cli failed first), - dropped main's `stop()` resets for `scheduledRefresh`, `stateRecoveryRefreshTask`, `watchedLink`, `changeWatcherID`, and `eventsFeedWarning`, - dropped main's asleep/unavailable publication through `replaceUnavailableCloudState` and the `eventsFeedWarning` link-error reporting, - kept `refreshDebounce` calls for a property main had removed. Redo the merge from git's automatic result: main's structure and logic stay, and the branch's intended changes are applied on top. Ports are no longer probed through provider exec; the cached scan is used until the cmux-tui link is up, then `ports(link:socketPath:)` refreshes `scannedPorts`/`currentPorts` for `publish`. The desktop row carries its private noVNC URL everywhere it is created (`desktopDisplayResource()`), the provider preview-endpoint machinery stays removed, and the old `VMTunnelManager.privateRouteBlocker()` text stays removed because that API no longer exists. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA5g4LcJ3QYAARgJjKCXvG * Re-merge CloudMachineLink.swift: restore the events recovery state the merge dropped The same merge (0ecbf91) resolved six hunks here by taking the branch side and lost main's events-subscription state: the eight stored properties (`eventsSubscriptionID`, `eventsReaderTask`, `eventsCursor`, `eventsRecoveryClock`, `eventsRecoveryPolicy`, `eventsRecoveryTask`, `eventsStabilityTask`, `eventsRecoveryPhase`) while every use of them survived, the `eventsCursor = nil; resetEventsRecovery()` at the start of `connect`, the `.connected` change event, the subscription id and cursor in `startEventsSubscription`, and the reader/recovery resets in `disconnect()` and `linkProcessDidExit`. Build error on main after the constant fix: Sources/Cloud/CloudMachineLink.swift:166: value of type 'CloudMachineLink' has no member 'eventsRecoveryClock' Keep the branch's additions (hub lease release, `eventsProcessExit` with `terminateAndWait` before a replacement reader, async `disconnect`/`linkProcessDidExit`) on top of main's logic. `startEventsSubscription(socketPath:cursor:)` is now async because it waits for the previous events child; `restartEventsSubscription`, `resumeEventsSubscription`, and `recoverEventsSubscription` propagate that. Callers already await them (actor). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA5g4LcJ3QYAARgJjKCXvG * Restore network_addresses plumbing and the vm terminal rename contract row Two more main-side pieces the 0ecbf91 merge dropped while keeping the rest of the feature (c8098d7): the `vm.cmux_remote_info` socket reply no longer carried `network_addresses` even though the CLI still parses it, and `cmux vm open --json` no longer forwarded it. Put both back so the chain works end to end again. Also restore the `vm terminal rename` row in docs/cli-contract.md, which the merge removed from the CLI contract table. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA5g4LcJ3QYAARgJjKCXvG --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
aerickson
pushed a commit
to aerickson/cmux
that referenced
this pull request
Sep 13, 2026
…h extens…" (manaflow-ai#11966) This reverts commit 4b3951c.
aerickson
pushed a commit
to aerickson/cmux
that referenced
this pull request
Sep 13, 2026
…ge broke (manaflow-ai#11999) * Restore CMUXCLI.vmAttachTransportUnsupportedCode so cmux-cli compiles Every "Nightly macOS build" run on main since 19f51d5 fails in build-nightly-app with: CLI/cmux.swift:13798: error: type 'CMUXCLI' has no member 'vmAttachTransportUnsupportedCode' Two independent changes crossed. The Cloud VPN branch (manaflow-ai#11789, commit c9272d3) removed the cmux-tui fallback helpers from CLI/CMUXCLI+VMTui.swift, including this constant, because every Cloud route now goes through the WireGuard hub. Five hours later main gained a new use of the same constant in shouldFallbackFromForcedSSH (c8098d7). The branch's later merges of main combined both sides without a textual conflict, and the squash merge landed the dangling reference on main. PR CI never compiled Swift for manaflow-ai#11789: web-typecheck failed, so linux-preflight failed and every macOS job was skipped, while the no-op "CI status fallback" workflow satisfied the required ci-status check and auto-merge went ahead. Restore the constant in CLI/CMUXCLI+VMTui.swift. The control plane still answers 409 vm_attach_transport_unsupported (web/services/vms/routeHelpers.ts), and VMSSHCommandTests.testVMSSHAliasUsesCmuxRemoteWhenProviderSSHIsUnmanaged covers the forced-SSH fallback that reads it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA5g4LcJ3QYAARgJjKCXvG * Drop stale SystemDefaultBrowserDetector.swift project entries The same squash merge (19f51d5, manaflow-ai#11789) re-added three cmux.xcodeproj entries for SystemDefaultBrowserDetector.swift: the PBXBuildFile, the PBXFileReference, and the cmux target's Sources entry. The file itself was deleted by the CEF revert (manaflow-ai#11966, e83b832), which also removed those entries on main; the VPN branch's merge of that revert kept them. The reference sits in no group, so Xcode resolves it against the project root and the app target fails with: error: Build input file cannot be found: '.../SystemDefaultBrowserDetector.swift' The nightly never reached this error because cmux-cli failed first. Remove the three entries, matching the revert. No other file reference in the project is orphaned or missing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA5g4LcJ3QYAARgJjKCXvG * Re-merge CmuxTuiSurfaceProviders.swift: keep main's state sync, apply the private-link port scan The VPN branch's merge of main (0ecbf91, "Merge origin/main into cloud tunnel PR branch") resolved seven conflict hunks in this file by taking the branch side, which: - left a `guard catalog.replaceResources(` with no `else` and Void `return`s inside `refresh(force:) -> Bool` (the app target did not parse; the nightly never got this far because cmux-cli failed first), - dropped main's `stop()` resets for `scheduledRefresh`, `stateRecoveryRefreshTask`, `watchedLink`, `changeWatcherID`, and `eventsFeedWarning`, - dropped main's asleep/unavailable publication through `replaceUnavailableCloudState` and the `eventsFeedWarning` link-error reporting, - kept `refreshDebounce` calls for a property main had removed. Redo the merge from git's automatic result: main's structure and logic stay, and the branch's intended changes are applied on top. Ports are no longer probed through provider exec; the cached scan is used until the cmux-tui link is up, then `ports(link:socketPath:)` refreshes `scannedPorts`/`currentPorts` for `publish`. The desktop row carries its private noVNC URL everywhere it is created (`desktopDisplayResource()`), the provider preview-endpoint machinery stays removed, and the old `VMTunnelManager.privateRouteBlocker()` text stays removed because that API no longer exists. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA5g4LcJ3QYAARgJjKCXvG * Re-merge CloudMachineLink.swift: restore the events recovery state the merge dropped The same merge (0ecbf91) resolved six hunks here by taking the branch side and lost main's events-subscription state: the eight stored properties (`eventsSubscriptionID`, `eventsReaderTask`, `eventsCursor`, `eventsRecoveryClock`, `eventsRecoveryPolicy`, `eventsRecoveryTask`, `eventsStabilityTask`, `eventsRecoveryPhase`) while every use of them survived, the `eventsCursor = nil; resetEventsRecovery()` at the start of `connect`, the `.connected` change event, the subscription id and cursor in `startEventsSubscription`, and the reader/recovery resets in `disconnect()` and `linkProcessDidExit`. Build error on main after the constant fix: Sources/Cloud/CloudMachineLink.swift:166: value of type 'CloudMachineLink' has no member 'eventsRecoveryClock' Keep the branch's additions (hub lease release, `eventsProcessExit` with `terminateAndWait` before a replacement reader, async `disconnect`/`linkProcessDidExit`) on top of main's logic. `startEventsSubscription(socketPath:cursor:)` is now async because it waits for the previous events child; `restartEventsSubscription`, `resumeEventsSubscription`, and `recoverEventsSubscription` propagate that. Callers already await them (actor). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA5g4LcJ3QYAARgJjKCXvG * Restore network_addresses plumbing and the vm terminal rename contract row Two more main-side pieces the 0ecbf91 merge dropped while keeping the rest of the feature (c8098d7): the `vm.cmux_remote_info` socket reply no longer carried `network_addresses` even though the CLI still parses it, and `cmux vm open --json` no longer forwarded it. Put both back so the chain works end to end again. Also restore the `vm terminal rename` row in docs/cli-contract.md, which the merge removed from the CLI contract table. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA5g4LcJ3QYAARgJjKCXvG --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #10197
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Reverts the Chromium browser pane feature, returning browser panes to WebKit-only rendering. The
--engineCLI flag and the in-process CEF integration are removed, along with all Chromium engine code, tests, and vendored CEF headers.Migration
enginefield that no longer exists; those snapshots restore as WebKit panes.--enginemust remove the flag from any saved commands or scripts.Written for commit 7c37ee2. Summary will update on new commits.