Repository navigation
fix(cmux-tui): make workspace clippy green and lint in every hosted lane - #11796
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 7 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (14)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
lawrencecchen
force-pushed
the
feat-tui-clippy-green
branch
from
September 3, 2026 05:58
d2ac8c3 to
b06f53c
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
wait_for_native_child_status is only called from tests since the process-tree owner refactor, so cargo clippy -D warnings on current main fails with dead_code.
Clippy ran only in the full lane, and the full lane is rarely used because its Windows smoke has been red (#11793). Eleven lint failures accumulated on main unnoticed. Run clippy in the focused lane too, so the gate everyone uses catches lint drift.
lawrencecchen
force-pushed
the
feat-tui-clippy-green
branch
from
September 3, 2026 06:18
b06f53c to
60bba98
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 3, 2026
4e30be8 cloud: compact access screen with the app icon (manaflow-ai#11819) 2558039 fix(cmux-tui): restore rustfmt import order (manaflow-ai#11808) f4e3d4f Keep client identity cache responsive during file lock waits (manaflow-ai#11795) 69dfcd1 fix(cmux-tui): make workspace clippy green and lint in every hosted lane (manaflow-ai#11796) 0f19be0 cloud: static model-plane env baked into the snapshot; create writes nothing into the guest (manaflow-ai#11813) c03ec18 cloud: add authenticated public VM domains (manaflow-ai#11692) e4325ab fix(cmux-tui): validate relay CLI values # Conflicts: # .github/workflows/cmux-tui.yml
lawrencecchen
added a commit
that referenced
this pull request
Sep 3, 2026
…ane (#11796) * fix(cmux-tui): clear stale clippy warnings * fix(cmux-tui): satisfy remaining clippy lints * fix(cmux-tui): clear remaining clippy warnings * fix(cmux-tui-core): keep the child-status wait helper test-only wait_for_native_child_status is only called from tests since the process-tree owner refactor, so cargo clippy -D warnings on current main fails with dead_code. * ci(cmux-tui): run clippy in every hosted mode Clippy ran only in the full lane, and the full lane is rarely used because its Windows smoke has been red (#11793). Eleven lint failures accumulated on main unnoticed. Run clippy in the focused lane too, so the gate everyone uses catches lint drift.
This was referenced Sep 3, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo clippy --workspace --all-targets --locked -- -D warningsfails on current main with eleven pre-existing warnings, and the check that would catch them runs only in the hosted full lane, which nobody can pass right now because its Windows smoke is red (#11793). So lint drift on main went unnoticed.This PR:
muts, and an unusedTreeViewmethod;wait_for_native_child_statustest-only, the one warning those commits no longer cover because main moved;cargo clippyin every hosted mode, not onlyfull, so the focused lane everyone uses catches lint drift.Trade-off stated: clippy adds a few minutes to each focused test job. The alternative, a PR-triggered clippy job, needs the Rust toolchain plus the Zig ghostty-vt build on every PR and is left as a follow-up.
Verification on the fleet builder against this exact tree:
cargo fmt --checkclean,cargo clippy --workspace --all-targets --locked -- -D warningsfinishes with no errors. Local codex review of 11763's diff was clean. 11758 and 11763 become redundant once this merges.Summary by cubic
Fixes the workspace clippy warnings on main and runs clippy in every hosted mode so lint drift no longer goes unnoticed.
Notes
wait_for_native_child_status, severalTreeViewmethods, andPendingRemoteRequestsaccessors as test-only, and removed the unusedactive_workspace_mutmethod.Written for commit 60bba98. Summary will update on new commits.