Skip to content

fix(cmux-tui): clear remaining clippy warnings - #11763

Closed
lawrencecchen wants to merge 1 commit into
feat-fix-tui-clippy-mainfrom
feat-tui-clippy-mechanical
Closed

lawrencecchen wants to merge 1 commit into
feat-fix-tui-clippy-mainfrom
feat-tui-clippy-mechanical

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

  • apply mechanical fixes for the remaining cmux-tui Clippy warnings
  • restrict test-only helpers to test builds and remove one unused helper
  • keep runtime behavior unchanged

Stacked on #11758.

Verification:

  • Blacksmith Testbox: cargo fmt --check
  • Blacksmith Testbox: cargo clippy --workspace --all-targets --locked -- -D warnings

Reference: https://doc.rust-lang.org/stable/clippy/usage.html


Summary by cubic

Clears the remaining Clippy warnings in cmux-tui and gates test-only helpers behind #[cfg(test)] so the workspace builds cleanly with -D warnings. Runtime behavior is unchanged.

  • Replaces unwrap_or_else with unwrap_or where the closure was constant, converts a then(...).unwrap_or(...) expression to if, drops unneeded mut bindings, and simplifies imports.
  • Moves is_sensitive_env_name, the PendingRemoteRequests accessors, and several TreeView helpers behind #[cfg(test)], and removes the unused active_workspace_mut.
  • Verified with cargo fmt --check and cargo clippy --workspace --all-targets --locked -- -D warnings.

Written for commit 73b31d6. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cmux166 Canceled Canceled Sep 3, 2026 4:09pm UTC
cmux41 Canceled Canceled Sep 3, 2026 4:09pm UTC

@coderabbitai

coderabbitai Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: f39d8dee-9f21-4e8a-a729-08fc547e6862

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen
lawrencecchen force-pushed the feat-fix-tui-clippy-main branch from 43dc772 to d2b1c14 Compare September 3, 2026 02:28
@lawrencecchen
lawrencecchen force-pushed the feat-tui-clippy-mechanical branch from 268df34 to ab10870 Compare September 3, 2026 02:34
@lawrencecchen
lawrencecchen force-pushed the feat-fix-tui-clippy-main branch from d2b1c14 to e30916a Compare September 3, 2026 02:39
@blacksmith-sh

This comment has been minimized.

@lawrencecchen
lawrencecchen force-pushed the feat-fix-tui-clippy-main branch from e30916a to 6768b97 Compare September 3, 2026 03:13
@lawrencecchen
lawrencecchen force-pushed the feat-tui-clippy-mechanical branch from ab10870 to 7c1c6cd Compare September 3, 2026 03:17
@lawrencecchen
lawrencecchen force-pushed the feat-fix-tui-clippy-main branch from 6768b97 to 0c8a318 Compare September 3, 2026 03:26
@lawrencecchen
lawrencecchen force-pushed the feat-tui-clippy-mechanical branch from 7c1c6cd to 8e7871b Compare September 3, 2026 03:32
@lawrencecchen
lawrencecchen force-pushed the feat-fix-tui-clippy-main branch from 0c8a318 to 58f94f0 Compare September 3, 2026 03:47
@lawrencecchen
lawrencecchen force-pushed the feat-tui-clippy-mechanical branch from 8e7871b to 47e8069 Compare September 3, 2026 03:50
@lawrencecchen
lawrencecchen force-pushed the feat-fix-tui-clippy-main branch from 58f94f0 to daeb2b5 Compare September 3, 2026 04:23
@lawrencecchen
lawrencecchen force-pushed the feat-tui-clippy-mechanical branch from 47e8069 to 866fa9e Compare September 3, 2026 04:23
@lawrencecchen
lawrencecchen force-pushed the feat-fix-tui-clippy-main branch from daeb2b5 to b18d04d Compare September 3, 2026 04:50
@lawrencecchen
lawrencecchen force-pushed the feat-tui-clippy-mechanical branch from 866fa9e to 8c7e5b9 Compare September 3, 2026 04:50
@cursor

cursor Bot commented Sep 3, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@lawrencecchen
lawrencecchen force-pushed the feat-fix-tui-clippy-main branch from b18d04d to 0731f86 Compare September 3, 2026 05:01
@lawrencecchen
lawrencecchen force-pushed the feat-tui-clippy-mechanical branch from 8c7e5b9 to c1c5708 Compare September 3, 2026 05:01
@cursor

cursor Bot commented Sep 3, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Closing as superseded. The full 12-file patch is already on main through merged PR #11796 (commit 69dfcd1). Rebasing this branch onto current main drops all three commits as already applied; no unique changes remain.

This branch was successfully deployed

2 active deployments
Preview – cmux41 — 73b31d6d Deployed Sep 3, 2026 by vercel[bot]
Preview – cmux166 — 73b31d6d Deployed Sep 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant