Skip to content

perf(tui): cache sidebar agent ordering - #11385

Open
lawrencecchen wants to merge 5 commits into
mainfrom
fix/sidebar-projection-order-wave183
Open

lawrencecchen wants to merge 5 commits into
mainfrom
fix/sidebar-projection-order-wave183

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on PR #11165.

Summary

  • Cache agent sidebar order instead of sorting on every render.
  • Skip cache work for views without an Agents level.
  • Invalidate on attention state, recency, agent surface roster, tree revisions, and direct tree surface sequence changes.
  • Preserve tab tree order and add behavior coverage, including test-first cache bypass coverage.

Verification

  • git diff --check passed.
  • Standalone rustfmt passed.
  • Canonical autoreview passed with gpt-5.6-sol/high, isolated and no web search.
  • Normal PR checks pass.
  • Focused hosted cmux-tui dispatch was blocked by GitHub API rate limit (HTTP 403).
  • No local cargo/rustc run per task constraints.

@cursor

cursor Bot commented Sep 1, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@vercel

vercel Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cmux166 Ready Ready Preview Sep 3, 2026 10:26am UTC
cmux41 Ready Ready Preview Sep 3, 2026 10:26am UTC

@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: d6333c0a-02fa-4836-beb0-e953c1528076

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread cmux-tui/crates/cmux-tui/src/sidebar_projection.rs Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread cmux-tui/crates/cmux-tui/src/sidebar_projection.rs Outdated
@lawrencecchen
lawrencecchen force-pushed the fix/sidebar-projection-order-wave183 branch from 3e8962f to 392b89e Compare September 2, 2026 11:59
@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Too many files changed for review (1385 files, 100 file limit).

@lawrencecchen
lawrencecchen changed the base branch from repair-pr11127-cmdline to main September 2, 2026 12:00
@teamleaderleo teamleaderleo added S3: minor Wrong behavior with a workaround area: sidebar The workspace sidebar: list, groups, status, reordering ready-to-land Reviewed and ready to land when CI is green labels Sep 30, 2026

This branch was successfully deployed

2 active deployments
Preview – cmux166 — 392b89e3 Deployed Sep 3, 2026 by vercel[bot]
Preview – cmux41 — 392b89e3 Deployed Sep 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: sidebar The workspace sidebar: list, groups, status, reordering ready-to-land Reviewed and ready to land when CI is green S3: minor Wrong behavior with a workaround

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants