Repository navigation
Fix startup benchmark tool path construction - #10263
lawrencecchen wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing this stale benchmark-path stack. The referenced startup benchmark files are absent from current main. Recreate the benchmark against the current runner contract when the measurement target is defined. |
Depends on #10238.
This branch replays the red test and green Path-based fix from PR10237 onto the current PR10238 head. The workflow expression
trusted_release /= "release" / "examples"evaluates string division before pathlib division and raises TypeError. The helper now constructs release/example paths as Path operands and has a focused behavior test.Checks: focused path test, cmux-tui SDK/spec checks, startup contract/claim checks. Rust/Cargo/Zig/Xcode builds were not run locally.