Skip to content

Fix startup benchmark tool path construction - #10263

Closed
lawrencecchen wants to merge 2 commits into
fix-pr10131-windows-evidencefrom
fix-pr10237-paths-on-10238
Closed

lawrencecchen wants to merge 2 commits into
fix-pr10131-windows-evidencefrom
fix-pr10237-paths-on-10238

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Depends on #10238.

This branch replays the red test and green Path-based fix from PR10237 onto the current PR10238 head. The workflow expression trusted_release /= "release" / "examples" evaluates string division before pathlib division and raises TypeError. The helper now constructs release/example paths as Path operands and has a focused behavior test.

Checks: focused path test, cmux-tui SDK/spec checks, startup contract/claim checks. Rust/Cargo/Zig/Xcode builds were not run locally.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e45a81b6-8526-4c90-976c-91a324ae6b36

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Closing this stale benchmark-path stack. The referenced startup benchmark files are absent from current main. Recreate the benchmark against the current runner contract when the measurement target is defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant