Skip to content

Fix startup benchmark tool path construction - #10237

Closed
lawrencecchen wants to merge 2 commits into
feat-tui-startup-benchmark-runner-recutfrom
fix-pr10131-startup-paths
Closed

lawrencecchen wants to merge 2 commits into
feat-tui-startup-benchmark-runner-recutfrom
fix-pr10131-startup-paths

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • move trusted startup benchmark tool path and digest recording into a tested Python helper
  • fix the hosted Windows/Linux/macOS failure caused by dividing two strings instead of joining Path values
  • run the helper regression test in the benchmark job before the build

Evidence

Red commit 3bb0241000 fails cmux-tui/scripts/tests/test_record_startup_tools.py with the hosted TypeError: unsupported operand type(s) for /: 'str' and 'str'.

Green commit 187dffe3e1 passes the same test and uses separate Path joins for release/examples.

No local Rust, Cargo, Zig, Xcode, or build command was run.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes CI failures in the startup benchmark by moving path construction and digest recording into a tested Python helper. Old behavior used inline workflow Python that divided strings when building paths (TypeError on hosted runners); new behavior uses pathlib.Path, validates tool presence under release/examples, and writes digests to GITHUB_OUTPUT. Side effect: adds a small pre-build test step.

  • Replaces the heredoc Python step in .github/workflows/cmux-tui-startup-benchmark.yml with cmux-tui/scripts/record_startup_tools.py.
  • Adds cmux-tui/scripts/tests/test_record_startup_tools.py and runs it before the build.
  • Helper emits binary_sha256 and supervisor_sha256; supports targets and platform suffixes.
  • No change to benchmark semantics; CI is now reliable across Windows, Linux, and macOS.

Written for commit 187dffe. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1bbd5753-0d95-4819-9ea4-5b33c7cd84ab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen

lawrencecchen commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Superseded by PR #10263, which replays this red/green path fix on the current PR #10238 stack. Closing this duplicate source PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant