Repository navigation
Fix startup benchmark tool path construction - #10237
Closed
lawrencecchen wants to merge 2 commits into
Closed
lawrencecchen wants to merge 2 commits into
lawrencecchen wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PathvaluesEvidence
Red commit
3bb0241000failscmux-tui/scripts/tests/test_record_startup_tools.pywith the hostedTypeError: unsupported operand type(s) for /: 'str' and 'str'.Green commit
187dffe3e1passes the same test and uses separatePathjoins forrelease/examples.No local Rust, Cargo, Zig, Xcode, or build command was run.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes CI failures in the startup benchmark by moving path construction and digest recording into a tested Python helper. Old behavior used inline workflow Python that divided strings when building paths (TypeError on hosted runners); new behavior uses
pathlib.Path, validates tool presence under release/examples, and writes digests toGITHUB_OUTPUT. Side effect: adds a small pre-build test step..github/workflows/cmux-tui-startup-benchmark.ymlwithcmux-tui/scripts/record_startup_tools.py.cmux-tui/scripts/tests/test_record_startup_tools.pyand runs it before the build.binary_sha256andsupervisor_sha256; supports targets and platform suffixes.Written for commit 187dffe. Summary will update on new commits.