Repository navigation
Tab drop settles into its slot (classic motion pass) - #282
Merged
Merged
Conversation
Red: the drop leaves animatesToDestination off, so AppKit drops the drag image under the pointer while the tab appears in its slot at once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The drop asks AppKit to slide the drag image to the slot the tab takes (animatesToDestination, the item's frame read from the strip before the move reflows it). The tab draws nothing there until the drag session ends (or 0.5 s), so the gliding image and the tab never show twice. Reduce Motion keeps the drop instant. Only the tab row moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…w only Review and CI: - The slot comes from the tab's index after the drop (pinned tabs stay first), measured on the strip as it was before the drop. - Only a drop carrying a tab transfer settles: a file dropped while a stale tab session lingers no longer hides that tab. - A slot not fully in view (the strip scrolls to reveal it) lands at once. - Tests pin reducesMotion off: the CI runner's setting decided them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review: a tab from another pane lands in a layout that changes under it (its emptied pane closes and the strip widens; fill-width tabs narrow), and the old visible check let a slot half under the pinned tabs of a scrolled strip settle before the strip scrolled. Settling now needs a reorder within the strip with every tab the slot passes fully on screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review: the clip view runs under the split-button lane, so a slot there counted as on screen, then the strip scrolled to reveal the selected tab. Every tab the slot passes must lie in the viewport outside that lane, the width the strip's own reveal uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review: pinned tabs sit before the scrolling viewport, so the viewport check refused every pinned reorder. A reorder never crosses the pinned boundary, so pinned tabs skip it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 11, 2026
teamleaderleo
added a commit
to manaflow-ai/cmux
that referenced
this pull request
Oct 12, 2026
main moved bonsplit to bc0d6dd (#19672); classic/tab-drop-settle-2 is that commit plus manaflow-ai/bonsplit#282 and nothing else. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
added a commit
to manaflow-ai/cmux
that referenced
this pull request
Oct 12, 2026
…19593) * Bonsplit: a tab reordered by drag settles into its slot Bumps vendor/bonsplit to classic/tab-drop-settle: the current pin plus manaflow-ai/bonsplit#282 only (bonsplit main also carries #272/#273, which this does not ship). A tab dropped within its strip slides into its slot instead of vanishing under the pointer; Reduce Motion and drops from other panes stay instant. Only the tab row moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bump bonsplit: main's pin plus the tab drop settle (#282) main moved bonsplit to bc0d6dd (#19672); classic/tab-drop-settle-2 is that commit plus manaflow-ai/bonsplit#282 and nothing else. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Classic cmux snaps a dropped tab: the drag image vanishes under the pointer and the tab appears in its new slot at once. A tab reordered within its strip now settles. The drop asks AppKit to slide the drag image into the slot where the pane placed the tab (
animatesToDestination, pinned tabs first). The real tab draws nothing there until the drag session ends (or 0.5 s), so it never shows twice.The drop lands at once, as before, in these cases:
Only the tab row moves. No pane, terminal or browser view animates or resizes.
Testing
TabDropSettleTests, red then green. Red on 85a5b5f: the drops landed butanimatesToDestinationstayed off and the drag image frame was unchanged. Green on 4df2b47. It covers left and right reorders, an unpinned tab dropped among pinned tabs, the session end showing the tab, and Reduce Motion.🤖 Generated with Claude Code