Skip to content

Right sidebar overhaul: host focus input and trailing tab bar inset - #264

Open
lawrencecchen wants to merge 2 commits into
mainfrom
feat-right-sidebar-overhaul
Open

lawrencecchen wants to merge 2 commits into
mainfrom
feat-right-sidebar-overhaul

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Sep 29, 2026 •

Copy link
Copy Markdown

Combines #242 and #262 for the cmux right sidebar overhaul (manaflow-ai/cmux#15534).

  • isMainContentFocused on BonsplitView: a host can say another surface owns input. The selected tab stays selected and its focus emphasis is removed. Defaults to true.
  • Trailing tab bar inset for the top-trailing pane, so the host can place a persistent right sidebar button there.

Validation: swift build passes on this branch.

🤖 Generated with Claude Code

lawrencecchen and others added 2 commits September 29, 2026 01:32
Hosts can draw a control over the corner where the top-trailing pane's tab
bar ends, such as a persistent sidebar toggle. The new
Appearance.tabBarTrailingInset reserves that width after the action lane
in only that pane (or the zoomed pane), mirroring tabBarLeadingInset.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d9cd3b38-e039-42f9-b886-9d668dd5a651

📥 Commits

Reviewing files that changed from the base of the PR and between 64d27c6 and 807bf5f.

📒 Files selected for processing (9)
  • Sources/Bonsplit/Internal/Models/SplitNode.swift
  • Sources/Bonsplit/Internal/Views/PaneContainerView.swift
  • Sources/Bonsplit/Internal/Views/SplitContainerView.swift
  • Sources/Bonsplit/Internal/Views/SplitNodeView.swift
  • Sources/Bonsplit/Internal/Views/SplitViewContainer.swift
  • Sources/Bonsplit/Internal/Views/TabBarView.swift
  • Sources/Bonsplit/Public/BonsplitConfiguration.swift
  • Sources/Bonsplit/Public/BonsplitView.swift
  • Tests/BonsplitTests/TopTrailingPaneTests.swift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant