Repository navigation
Reserve a trailing tab bar inset for the top-trailing pane - #262
Closed
lawrencecchen wants to merge 1 commit into
Closed
lawrencecchen wants to merge 1 commit into
lawrencecchen wants to merge 1 commit into
Conversation
Hosts can draw a control over the corner where the top-trailing pane's tab bar ends, such as a persistent sidebar toggle. The new Appearance.tabBarTrailingInset reserves that width after the action lane in only that pane (or the zoomed pane), mirroring tabBarLeadingInset. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 29, 2026
Author
|
Superseded by #264, which combines this change with the other right sidebar Bonsplit change for manaflow-ai/cmux#15534. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Appearance.tabBarTrailingInset. Only the pane whose tab bar ends at the container's top-trailing corner (or the zoomed pane) reserves that width after its action lane, as a drag zone painted with the bar color. It mirrorstabBarLeadingInset, which reserves traffic-light space in the top-leading pane.cmux uses it to draw a persistent right-sidebar toggle over that corner without covering the split buttons.
SplitNode.topTrailingPaneIdtakes the trailing child of side-by-side splits and the top child of stacked splits.swift test --filter TopTrailingPaneTestspasses (4 tests).🤖 Generated with Claude Code
Summary by cubic
Adds
Appearance.tabBarTrailingInset, which reserves a host-defined width after the action lane in the top-trailing pane's tab bar so hosts can draw a control (like a persistent sidebar toggle) over that corner. It mirrorstabBarLeadingInset: only the pane at the container's top-trailing corner, or the zoomed pane, reserves the width, painted with the bar color.SplitNode.topTrailingPaneIdidentifies that pane (trailing child of side-by-side splits, top child of stacked splits); tests cover single, side-by-side, stacked, and nested layouts.Written for commit 1d1f0fb. Summary will update on new commits.