Skip to content

Add dep on packaging #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2023
Merged

Add dep on packaging #795

merged 1 commit into from
Aug 25, 2023

Conversation

@poodlewars
Copy link
Collaborator

@poodlewars poodlewars commented Aug 25, 2023

Required for:

from arcticdb.util._versions import IS_PANDAS_TWO

but seems to have been missed.

@poodlewars poodlewars added the bug Something isn't working label Aug 25, 2023
jjerphan
jjerphan reviewed Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

packaging was already used before #540. Until now, it might have been pulled by other dependencies, but it indeed need to be specified.

Could you also update environment_unix.yml to add it as a dependency?

jjerphan
jjerphan approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @poodlewars.

@poodlewars
Add dep on packaging
aababa5 
Required for:

```
from arcticdb.util._versions import IS_PANDAS_TWO
```

but seems to have been missed.
@poodlewars poodlewars merged commit e90835a into master Aug 25, 2023
@jjerphan jjerphan deleted the poodlewars-patch-2 branch August 25, 2023 20:05
jjerphan added a commit to regro-cf-autotick-bot/arcticdb-feedstock that referenced this pull request Aug 29, 2023
@jjerphan
Add packaging as a runtime dependency
916eb4d 
See: man-group/ArcticDB#795

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan mentioned this pull request Aug 29, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjerphan jjerphan jjerphan approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@poodlewars @jjerphan