Skip to content

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Aug 28, 2023

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
msgpack-c 6.1.0 Anaconda-Server Badge
protobuf 24.2 Anaconda-Server Badge
recycle 7.0.0 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • wheel
  • pytz
  • hypothesis

Packages found in the meta.yaml but not found by source code inspection:

  • decorator
  • protobuf
  • prometheus_client
  • grpcio-tools
  • python-xxhash

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6004768048, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

lz4_c:
- 1.9.3
msgpack_c:
- '6'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjerphan any idea why this has changed?

Copy link
Member

@jjerphan jjerphan Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

msgpack_c and msgpack_cxx aren't globally pinned since yesterday.

See conda-forge/conda-forge-pinning-feedstock#4854.

Copy link
Contributor

@mehertz mehertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as long as @jjerphan think the msgpack change is ok

@jjerphan
Copy link
Member

jjerphan commented Aug 29, 2023

Before merging this PR, can someone from Man Group confirm that the release candidate for 2.0 properly can be used by internal and external users?

@jamesmunro
Copy link
Contributor

Before merging this PR, can someone from Man Group confirm that the release candidate for 2.0 properly can be used by internal and external users?

Yes, can be used. v2.0 does have breaking changes.

@jjerphan
Copy link
Member

jjerphan commented Aug 29, 2023

Even though msgpack_c 6 will be used without the conda-forge global pinning since it is the last version, I have pinned msgpack_c 6 as recommended by conda-forge:

If a package is not pinned in conda-forge-pinning, then the pinning needs to be done manually. If the package is a C/C++ library with a C/C++ API that is consumed and linked to by other libraries, then that package is a candidate to be added to conda-forge-pinning. Please open an issue in conda-forge-pinning-feedstock for discussion.

msgpack_c 6 has been used in the past, but this makes sure this will be used in the future (eventhough of msgpack_c seems not to have new versions published often).

I also just added packaging as a runtime dependency as it has been explicitly introduced by man-group/ArcticDB#795.

Given your confirmation, 2.0 is releasable to me if the CI checks pass.

@jjerphan jjerphan added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Aug 29, 2023
@vasil-pashov
Copy link
Contributor

@jjerphan

Before merging this PR, can someone from Man Group confirm that the release candidate for 2.0 properly can be used by internal and external users?

Did some sanity tests in BQNT. It can read libraries, list symbols, create libraries. I think we're good to go.

@jjerphan jjerphan added the automerge Merge the PR when CI passes label Aug 29, 2023
@github-actions github-actions bot merged commit 9ded7ff into conda-forge:main Aug 29, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 2.0.0_h8fc0b5 branch August 29, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants