Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load_module deprecation warnings for Python >= 3.10. #432

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

fschulze
Copy link
Contributor

The lint and mypy errors are also on master. I guess newer mypy added some errors and the Python versions changed because of latest Python release since last run 6 months ago.

@malthe
Copy link
Owner

malthe commented Dec 11, 2024

I don't understand why linting errors mean we have to change this code? Did something not work before?

@fschulze
Copy link
Contributor Author

This change is only about the deprecation warning. I only meant that current tox run isn't passing, because of unrelated changes outside of Chameleon and this PR.

@malthe
Copy link
Owner

malthe commented Dec 11, 2024

OK, I somehow thought all of this had been revamped in #396.

@fschulze
Copy link
Contributor Author

That was how to determine the module name etc. This is about changes in the importlib and zipimport modules in Python 3.10. It looks like the removal of those methods was planned for 3.12 but postponed.

@malthe malthe merged commit 9ea8bac into malthe:master Dec 11, 2024
@malthe
Copy link
Owner

malthe commented Dec 11, 2024

Not sure why the testing workflow was disabled. Yes, the repository has had no activity for 60 days, but now it has thanks to your pull request.

There seems to be some minor problems: https://github.com/malthe/chameleon/actions/runs/12280815714/job/34268167089.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants