-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows regression #396
Conversation
Pull Request Test Coverage Report for Build 7186272057
💛 - Coveralls |
@fschulze there were some issues on Windows and I decided to go back on the The way I see it, the
With this change, templates don't know about a spec (except for the Instead, a template file class knows about On the objectively positive side, we now test on Windows and tests are green. |
Could you yank the broken release? You increased the minimum Python to 3.8 and I now got a failure in another project which still supports Python 3.7. |
Here's the test failure that motivated the dropping of Python 3.7. But it's also EOL, so to be honest I don't feel we should make much of an effort to support it – unless there are some good arguments that I don't know about? Shouldn't The problem with just yanking the release is that it actually solves #394 which was an issue for some other users. |
It is using 4.3.0 which is broken for Python 3.7 on Windows, because the fix is in 4.4.0 which removed Python 3.7. So it would be nice to yank 4.3.0. |
@fschulze done! |
@fschulze 4.4.2 should work on Windows – but it does still require Python 3.8+. |
Revert most of the spec/filename changes introduced in ad7a498, instead supporting
pathlib.Path
andzipfile.Path
directly.Note that this change also adds Windows to the testing matrix (replacing Ubuntu 20.04), motivated by #395 in which a regression affected the Windows platform, we want to run tests on Windows in addition to Ubuntu Linux.