Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#41] [Chore] Fix error from Danger #40

Merged
merged 11 commits into from
Jun 21, 2021
Merged

[#41] [Chore] Fix error from Danger #40

merged 11 commits into from
Jun 21, 2021

Conversation

malparty
Copy link
Owner

@malparty malparty commented Jun 18, 2021 •
edited
Loading

[#41] [Chore] Remove false positives in Review workflow

What happened

No more fasle ❌ during pull requests.

Insight

  • Removed code coverage tasks from Danger
  • added Brakeman ignore config file to ignore the false positive (asking to update to > 2.2 when current package is already 2.10)

Proof Of Work

Check bellow this PR: Review workflow passed! 👇

@malparty malparty self-assigned this Jun 18, 2021
@malparty malparty added !ci-cd Work made on task automations for integration & deployment bug Something isn't working Chore priority: low @0.2.0 First usable release. labels Jun 18, 2021
@malparty malparty added this to the 0.2.0 milestone Jun 18, 2021
@malparty malparty changed the title WIP - [Chore] Fix error from Danger [#41] [Chore] Fix error from Danger Jun 18, 2021
@malparty malparty requested review from ankitkalia1195 and junan June 18, 2021 08:55
@malparty malparty removed the bug Something isn't working label Jun 18, 2021
@malparty malparty added the @0.3.0 v0.3.0 third week release label Jun 21, 2021
@malparty malparty merged commit 0486376 into develop Jun 21, 2021
@malparty malparty deleted the chore/fix-danger-coverage-error branch June 23, 2021 08:55
@malparty malparty removed this from the 0.2.0 milestone Jun 23, 2021
@malparty malparty added this to the 0.3.0 milestone Jun 23, 2021
@malparty malparty linked an issue Jun 28, 2021 that may be closed by this pull request
[Chore] Remove false positives in Review workflow #41
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitkalia1195 ankitkalia1195 ankitkalia1195 approved these changes

@junan junan junan approved these changes

Assignees

@malparty malparty

Labels
Chore !ci-cd Work made on task automations for integration & deployment priority: low @0.2.0 First usable release. @0.3.0 v0.3.0 third week release
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

[Chore] Remove false positives in Review workflow
3 participants
@malparty @junan @ankitkalia1195