Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Remove false positives in Review workflow #41

Closed
malparty opened this issue Jun 18, 2021 · 0 comments · Fixed by #40
Closed

[Chore] Remove false positives in Review workflow #41

malparty opened this issue Jun 18, 2021 · 0 comments · Fixed by #40
Assignees
@malparty
Labels
Chore !ci-cd Work made on task automations for integration & deployment priority: low @0.2.0 First usable release. @0.3.0 v0.3.0 third week release
Milestone
0.3.0

Comments

@malparty
Copy link
Owner

Why?

Many times while all auto tests are passing, Pull Requests are showed as "NOK" ❌ simply because

  • Danger cannot find code coverage data
  • Danger cannot find undercover reports
  • false positive: Danger indicates a package vulnerability "2.10 is at risk, please update > 2.2"

Who benefits?

Dev team & code reviewers ;-)
@malparty malparty added !ci-cd Work made on task automations for integration & deployment @0.2.0 First usable release. Chore priority: low labels Jun 18, 2021
@malparty malparty added this to the 0.2.0 milestone Jun 18, 2021
@malparty malparty self-assigned this Jun 18, 2021
@malparty malparty mentioned this issue Jun 18, 2021
Merged
malparty added a commit that referenced this issue Jun 21, 2021
@malparty
Merge pull request #40 from malparty/chore/fix-danger-coverage-error
0486376 
[#41] [Chore] Fix error from Danger
@malparty malparty added the @0.3.0 v0.3.0 third week release label Jun 23, 2021
@malparty malparty modified the milestones: 0.2.0, 0.3.0 Jun 23, 2021
@malparty malparty mentioned this issue Jun 25, 2021
Merged
@malparty malparty linked a pull request Jun 28, 2021 that will close this issue
[#41] [Chore] Fix error from Danger #40
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malparty malparty

Labels
Chore !ci-cd Work made on task automations for integration & deployment priority: low @0.2.0 First usable release. @0.3.0 v0.3.0 third week release
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

[#41] [Chore] Fix error from Danger malparty/google-search-ruby
1 participant
@malparty