Stop caching failed PDF rendering logs; DMOJ#1119

judge/signals.py

@@ -41,10 +41,8 @@ def problem_update(sender, instance, **kwargs):
                        for lang, _ in settings.LANGUAGES])
     cache.delete_many(['generated-meta-problem:%s:%d' % (lang, instance.id) for lang, _ in settings.LANGUAGES])
 
-    if hasattr(settings, 'DMOJ_PDF_PROBLEM_CACHE'):
-        for lang, _ in settings.LANGUAGES:
-            unlink_if_exists(get_pdf_path('%s.%s.pdf' % (instance.code, lang)))
-            unlink_if_exists(get_pdf_path('%s.%s.log' % (instance.code, lang)))
+    for lang, _ in settings.LANGUAGES:
+        unlink_if_exists(get_pdf_path('%s.%s.pdf' % (instance.code, lang)))
 
 
 @receiver(post_save, sender=Profile)

judge/views/problem.py

@@ -241,13 +241,8 @@ def get(self, request, *args, **kwargs):
         except ProblemTranslation.DoesNotExist:
             trans = None
 
-        error_cache = os.path.join(settings.DMOJ_PDF_PROBLEM_CACHE, '%s.%s.log' % (problem.code, language))
         cache = os.path.join(settings.DMOJ_PDF_PROBLEM_CACHE, '%s.%s.pdf' % (problem.code, language))
 
-        if os.path.exists(error_cache):
-            with open(error_cache) as f:
-                return HttpResponse(f.read(), status=500, content_type='text/plain')
-
         if not os.path.exists(cache):
             self.logger.info('Rendering: %s.%s.pdf', problem.code, language)
             with DefaultPdfMaker() as maker, translation.override(language):
@@ -268,8 +263,6 @@ def get(self, request, *args, **kwargs):
                     maker.load(file, os.path.join(settings.DMOJ_RESOURCES, file))
                 maker.make()
                 if not maker.success:
-                    with open(error_cache, 'wb') as f:
-                        f.write(maker.log)
                     self.logger.error('Failed to render PDF for %s', problem.code)
                     return HttpResponse(maker.log, status=500, content_type='text/plain')
                 shutil.move(maker.pdffile, cache)