Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop caching failed PDF rendering logs #1119

Closed
Xyene opened this issue Oct 18, 2019 · 0 comments · Fixed by #1145
Closed

Stop caching failed PDF rendering logs #1119

Xyene opened this issue Oct 18, 2019 · 0 comments · Fixed by #1145
Labels
bug ui

Comments

@Xyene
Copy link
Member

Xyene commented Oct 18, 2019 •
edited
Loading

Sometimes PDF rendering fails spuriously:

{ TimeoutError: waiting for selector ".math-loaded" failed: timeout 15000ms exceeded
    at new WaitTask (/usr/lib/node_modules/puppeteer/lib/DOMWorld.js:554:28)
    at DOMWorld._waitForSelectorOrXPath (/usr/lib/node_modules/puppeteer/lib/DOMWorld.js:483:22)
    at DOMWorld.waitForSelector (/usr/lib/node_modules/puppeteer/lib/DOMWorld.js:437:17)
    at Frame.waitForSelector (/usr/lib/node_modules/puppeteer/lib/FrameManager.js:606:47)
    at Frame.<anonymous> (/usr/lib/node_modules/puppeteer/lib/helper.js:109:23)
    at Page.waitForSelector (/usr/lib/node_modules/puppeteer/lib/Page.js:1073:29)
    at Promise.resolve.then (/tmp/d3d31e6e-8263-11e9-99b9-f23c91f5256b/_render.js:9:20)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7) name: 'TimeoutError' }

We shouldn't be caching the error logs, and just regenerate on the following page load.
@Xyene Xyene changed the title PDF rendering times out instantly Stop caching failed PDF rendering logs Oct 18, 2019
Ninjaclasher added a commit to Ninjaclasher/site that referenced this issue Oct 26, 2019
@Ninjaclasher
Stop caching failed PDF rendering logs; DMOJ#1119
917eda1
@Ninjaclasher Ninjaclasher mentioned this issue Oct 26, 2019
Merged
Xyene pushed a commit that referenced this issue Oct 27, 2019
@Ninjaclasher @Xyene
Stop caching failed PDF rendering logs; #1119
86ee0b1
malbareda pushed a commit to malbareda/JOEL-web that referenced this issue Jan 4, 2024
@Ninjaclasher @Xyene
Stop caching failed PDF rendering logs; DMOJ#1119
2da3164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop caching failed PDF rendering logs; #1119 Ninjaclasher/site
1 participant
@Xyene