conditionally remove long-deprecated in C++ "register" in types#5
conditionally remove long-deprecated in C++ "register" in types#5dimpase wants to merge 0 commit intomalb:masterfrom
Conversation
|
Is Sage compiling M4RIE as C++ and not as C? |
|
Sage does the default thing when building m4rie. The error I see happens when building the interface to it, on macOS with a recent xcode, something that used Apple clang 16 or 17 (it enforces C++17 by default). The error goes away if I remove |
|
Perhaps it's actually a strictly Sage bug - for some strange reason Let me try to remove that |
|
OK, I'll change this to something which only touches one header file, and is conditional on being compiled with C++. |
See #6 for a better fix.
in particular, as Sage moves to C++17, it becomes crucial. And "register" has purely nostalgic meaning nowadays, anyway