Conversation
|
(the README.md text for Windows support is from m4ri) |
|
it's quite common to have a script called |
|
Yes, having an |
dimpase
left a comment
There was a problem hiding this comment.
looks OK, that typo should be fixed. I haven't tried these on a Windows machine though
That'd be fab. |
d18c1c7 to
443600a
Compare
|
Thank you for the reviews, I added autogen.sh and updated the documentations and workflows. |
37610e1 to
8f17409
Compare
|
while you at it, can we also get C++17 compliance, by removing |
this is now #5 |
|
Ah, sorry for the late response. Thank you for the PR. |
Adding instructions to build m4rie on MinGW on Windows and CI. On MSYS2, the Linux symlink from
m4rietosrcis not properly recognized. Therefore, we need to create the symlink manually before runningautoreconf. A cleaner solution will be to add a shell script to run thelnandautoreconfcommands instead of just runningautoreconf, but that will force people to change their workflow. Hence, I choose this one instead. What do you think? @malbAs a context: sagemath/sage#38872
cc: @dimpase @tobiasdiez