Skip to content

Support MinGW build and added CI#4

Merged
malb merged 1 commit intomalb:masterfrom
ptrrsn:mingw_build
Jun 28, 2025
Merged

Support MinGW build and added CI#4
malb merged 1 commit intomalb:masterfrom
ptrrsn:mingw_build

Conversation

@ptrrsn
Copy link
Copy Markdown
Contributor

@ptrrsn ptrrsn commented Jun 26, 2025

Adding instructions to build m4rie on MinGW on Windows and CI. On MSYS2, the Linux symlink from m4rie to src is not properly recognized. Therefore, we need to create the symlink manually before running autoreconf. A cleaner solution will be to add a shell script to run the ln and autoreconf commands instead of just running autoreconf, but that will force people to change their workflow. Hence, I choose this one instead. What do you think? @malb

As a context: sagemath/sage#38872

cc: @dimpase @tobiasdiez

@ptrrsn
Copy link
Copy Markdown
Contributor Author

ptrrsn commented Jun 26, 2025

(the README.md text for Windows support is from m4ri)

@dimpase
Copy link
Copy Markdown

dimpase commented Jun 26, 2025

it's quite common to have a script called bootstrap or autogen to run the needed autotools and related commands.

@ptrrsn
Copy link
Copy Markdown
Contributor Author

ptrrsn commented Jun 26, 2025

Yes, having an autogen will be ideal. @malb can I add an autogen to support Windows that will replace the direct autoreconf --install call?

Copy link
Copy Markdown

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK, that typo should be fixed. I haven't tried these on a Windows machine though

@malb
Copy link
Copy Markdown
Owner

malb commented Jun 26, 2025

Yes, having an autogen will be ideal. @malb can I add an autogen to support Windows that will replace the direct autoreconf --install call?

That'd be fab.

@ptrrsn ptrrsn force-pushed the mingw_build branch 4 times, most recently from d18c1c7 to 443600a Compare June 26, 2025 20:08
@ptrrsn ptrrsn changed the title Add MinGW build instructions and CI Support MinGW build and added CI Jun 26, 2025
@ptrrsn
Copy link
Copy Markdown
Contributor Author

ptrrsn commented Jun 26, 2025

Thank you for the reviews, I added autogen.sh and updated the documentations and workflows.

@ptrrsn ptrrsn force-pushed the mingw_build branch 3 times, most recently from 37610e1 to 8f17409 Compare June 26, 2025 20:16
@dimpase
Copy link
Copy Markdown

dimpase commented Jun 27, 2025

while you at it, can we also get C++17 compliance, by removing register everywhere?

@dimpase
Copy link
Copy Markdown

dimpase commented Jun 27, 2025

while you at it, can we also get C++17 compliance, by removing register everywhere?

this is now #5

@ptrrsn
Copy link
Copy Markdown
Contributor Author

ptrrsn commented Jun 27, 2025

Ah, sorry for the late response. Thank you for the PR.

@malb malb merged commit 9f2d97a into malb:master Jun 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants