chore: added a condition to restrict duplicate issue assignee creation

[NarayanBavisetti]

Description

added a condition to restrict duplicate issue assignee creation.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

• Bug Fixes
  • Improved issue creation and update process by adding conflict resolution for assignees and labels.
  • Enhanced error handling during bulk creation of related issue entities.

[coderabbitai]

Walkthrough

The pull request modifies the IssueSerializer and IssueCreateSerializer classes in two separate files by adding the ignore_conflicts=True parameter to bulk_create method calls for IssueAssignee and IssueLabel. This change enhances the robustness of issue-related operations by allowing the serializers to handle potential conflicts during bulk creation of assignees and labels without raising errors, effectively skipping conflicting records.

Changes

File	Change Summary
apiserver/plane/api/serializers/issue.py	Added ignore_conflicts=True to bulk_create calls in IssueSerializer.update() method
apiserver/plane/app/serializers/issue.py	Added ignore_conflicts=True to bulk_create calls in IssueCreateSerializer.update() and create() methods

Possibly related PRs

• fix: issue serializer to remove deleted labels and assignees #6241: Focuses on handling assignees and labels in the IssueSerializer class, with similar concerns about managing issue-related entities

Suggested labels

🐛bug, ⚙️backend

Suggested reviewers

• pablohashescobar
• sriramveeraghanta
• pushya22

Poem

🐰 In the realm of code, where conflicts arise,
A rabbit's magic smooths out the surprise
Ignore the clash, let data flow free
Bulk create with grace, no error to see
Serializers dance, conflicts take flight! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 586a320 and aa2375a.

📒 Files selected for processing (2)

• apiserver/plane/api/serializers/issue.py (2 hunks)
• apiserver/plane/app/serializers/issue.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: lint-apiserver
• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (3)

apiserver/plane/api/serializers/issue.py (2)

228-228: Reconsider the necessity of ignore_conflicts=True.

Similar to the assignees case, ignore_conflicts=True seems unnecessary here since existing labels are already deleted using IssueLabel.objects.filter(issue=instance).delete() before the bulk creation.

---

210-210: Reconsider the necessity of ignore_conflicts=True.

The ignore_conflicts=True parameter seems unnecessary here since existing assignees are already deleted using IssueAssignee.objects.filter(issue=instance).delete() before the bulk creation. This makes conflicts unlikely as the old records are removed.

Let's verify if there are any unique constraints that could cause conflicts:

apiserver/plane/app/serializers/issue.py (1)

206-206: Inconsistent handling between create and update methods.

While ignore_conflicts=True is added to bulk_create calls in the update method, it's missing in the create method. This creates inconsistent behavior between creating and updating issues.

Let's check if there are any reported issues about duplicate assignees during creation:

Also applies to: 224-224

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.