-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PE-93] regression: mention users highlight color, reomve bot users from search list #6258
Conversation
WalkthroughThis pull request introduces modifications to user mention filtering and styling across multiple components. In the API server, the search endpoint for user mentions now excludes bot members from query results. Simultaneously, the frontend components for user mentions have been updated to adjust the visual representation of user mentions, particularly focusing on how current user and deactivated user states are displayed. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apiserver/plane/app/views/search/base.py (1)
277-277
: Exclude bot members successfully, but address the long line.Including “member__is_bot=False” fulfills the goal of filtering out bot members. However, Ruff warns that this line exceeds the recommended length (E501). Here is a fix to break it into multiple lines:
- users = ProjectMember.objects.filter(q, is_active=True, project_id=project_id, workspace__slug=slug, member__is_bot=False) + users = ProjectMember.objects.filter( + q, + is_active=True, + project_id=project_id, + workspace__slug=slug, + member__is_bot=False + )🧰 Tools
🪛 Ruff (0.8.2)
277-277: Line too long (108 > 88)
(E501)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apiserver/plane/app/views/search/base.py
(1 hunks)space/core/components/editor/embeds/mentions/user.tsx
(1 hunks)web/core/components/editor/embeds/mentions/user.tsx
(1 hunks)
🧰 Additional context used
🪛 Ruff (0.8.2)
apiserver/plane/app/views/search/base.py
277-277: Line too long (108 > 88)
(E501)
🔇 Additional comments (2)
space/core/components/editor/embeds/mentions/user.tsx (1)
29-34
: Highlight logic is consistent with the new requirement.
The default mention highlight is now blue, switching to yellow for self-mentions. This change aligns well with the PR objective of distinguishing between self and other user mentions. No issues detected.
web/core/components/editor/embeds/mentions/user.tsx (1)
61-63
: Self-mention styling matches the updated design.
Here, the highlight swaps to yellow for the current user. This is consistent with the approach in the other mention component. No issues detected.
Description
This PR fixes the following bugs-
Type of Change
Summary by CodeRabbit
New Features
Style