Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-93] regression: mention users highlight color, reomve bot users from search list #6258

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

aaryan610
Copy link
Collaborator

@aaryan610 aaryan610 commented Dec 23, 2024

Description

This PR fixes the following bugs-

  1. User highlight color when mentioned(Yellow for slef mention, blue for other users).
  2. Remove bot users from the list of users in the search endpoint.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • New Features

    • Enhanced search functionality to exclude bot members from user mentions in results.
  • Style

    • Updated visual representation of user mentions based on user status, improving clarity for active and deactivated users.

Copy link
Contributor

coderabbitai bot commented Dec 23, 2024

Walkthrough

This pull request introduces modifications to user mention filtering and styling across multiple components. In the API server, the search endpoint for user mentions now excludes bot members from query results. Simultaneously, the frontend components for user mentions have been updated to adjust the visual representation of user mentions, particularly focusing on how current user and deactivated user states are displayed.

Changes

File Change Summary
apiserver/plane/app/views/search/base.py Added member__is_bot=False to filter out bot members from user mention search results
space/core/components/editor/embeds/mentions/user.tsx Updated class names for user mention styling, reversing conditional logic for background and text colors
web/core/components/editor/embeds/mentions/user.tsx Modified class names to change visual representation of user mentions based on user status

Possibly related PRs

Suggested labels

🐛bug, 🌐frontend, ✍️editor

Suggested reviewers

  • SatishGandham
  • NarayanBavisetti
  • pushya22

Poem

🐰 A rabbit's tale of mentions bright,
Where bots are filtered out of sight,
With colors dancing, soft and clear,
Our user mentions now appear!
A coding quest of style and grace,
Bringing users to their rightful place! 🎨

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aaryan610 aaryan610 added this to the v0.24.0 milestone Dec 23, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apiserver/plane/app/views/search/base.py (1)

277-277: Exclude bot members successfully, but address the long line.

Including “member__is_bot=False” fulfills the goal of filtering out bot members. However, Ruff warns that this line exceeds the recommended length (E501). Here is a fix to break it into multiple lines:

- users = ProjectMember.objects.filter(q, is_active=True, project_id=project_id, workspace__slug=slug, member__is_bot=False)
+ users = ProjectMember.objects.filter(
+     q,
+     is_active=True,
+     project_id=project_id,
+     workspace__slug=slug,
+     member__is_bot=False
+ )
🧰 Tools
🪛 Ruff (0.8.2)

277-277: Line too long (108 > 88)

(E501)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f5def3 and a4f56bd.

📒 Files selected for processing (3)
  • apiserver/plane/app/views/search/base.py (1 hunks)
  • space/core/components/editor/embeds/mentions/user.tsx (1 hunks)
  • web/core/components/editor/embeds/mentions/user.tsx (1 hunks)
🧰 Additional context used
🪛 Ruff (0.8.2)
apiserver/plane/app/views/search/base.py

277-277: Line too long (108 > 88)

(E501)

🔇 Additional comments (2)
space/core/components/editor/embeds/mentions/user.tsx (1)

29-34: Highlight logic is consistent with the new requirement.

The default mention highlight is now blue, switching to yellow for self-mentions. This change aligns well with the PR objective of distinguishing between self and other user mentions. No issues detected.

web/core/components/editor/embeds/mentions/user.tsx (1)

61-63: Self-mention styling matches the updated design.

Here, the highlight swaps to yellow for the current user. This is consistent with the approach in the other mention component. No issues detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants