Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-2455] fix: Quick action menu is overflowing for created link notification under inbox #5607

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

Jimmycutie
Copy link
Contributor

@Jimmycutie Jimmycutie commented Sep 13, 2024

Problem Statement

Quick action menu on hover was overflowing for created and updated link notifications in inbox.

Solution

When the links were long the words weren't wrapping correctly inside the div which lead it to push the menu items to right and made them overflow. The wrap text property was set to word which only wrapped whole words. Changing it to all fixed the issue.

Screenshots and Media

Before:

image

After:

image

References

[WEB-2455]

Summary by CodeRabbit

  • New Features
    • Improved readability of notification messages by allowing text to break at any character, preventing overflow in the notification card.

Copy link
Contributor

coderabbitai bot commented Sep 13, 2024

Walkthrough

The changes in this pull request involve a modification to the NotificationItem component's CSS class. The whitespace-normal class has been updated to whitespace-normal break-all, which alters how text is displayed in notification messages. This adjustment allows for word breaks at any character, improving the handling of lengthy messages within the notification card.

Changes

File Path Change Summary
web/core/components/workspace-notifications/sidebar/notification-card/item.tsx Updated CSS class from whitespace-normal to whitespace-normal break-all for better text handling in notifications.

Possibly related PRs

Suggested labels

🐛bug, 🌐frontend, 🌐web

Poem

In the land of code where bunnies play,
A change was made to brighten the day.
With words that break and fit just right,
Notifications now bring pure delight!
Hopping through messages, clear and bright,
Our little changes make everything light! 🐇✨

Tip

OpenAI O1 model for chat
  • We have deployed OpenAI's latest O1 model for chat.
  • OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
  • Please share any feedback with us in the discussions post.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f155a13 and 1ec6c5b.

Files selected for processing (1)
  • web/core/components/workspace-notifications/sidebar/notification-card/item.tsx (1 hunks)
Additional comments not posted (1)
web/core/components/workspace-notifications/sidebar/notification-card/item.tsx (1)

89-89: LGTM!

The change from whitespace-normal to whitespace-normal break-all is a good fix for the quick action menu overflow issue. It allows text to break at any character, ensuring that longer messages fit within the designated area without overflowing.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jimmycutie Jimmycutie self-assigned this Sep 13, 2024
@Jimmycutie Jimmycutie added 🐛bug Something isn't working 🌟enhancement New feature or request 🌐frontend 🌐web Issues related to our web product and removed 🌟enhancement New feature or request labels Sep 13, 2024
@Jimmycutie Jimmycutie added this to the v0.23-dev milestone Sep 13, 2024
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with comment activity is still occurring. Could you please take a look at it?

Screenshot 2024-09-16 at 6 43 39 PM

@Jimmycutie
Copy link
Contributor Author

The issue with comment activity is still occurring. Could you please take a look at it?

Screenshot 2024-09-16 at 6 43 39 PM

The fix is working for every type of notification.
image

@pushya22 pushya22 merged commit bf6588b into preview Sep 30, 2024
14 of 15 checks passed
@pushya22 pushya22 deleted the fix-notification_quick_action_menu_overflow branch September 30, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend 🌐web Issues related to our web product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants