-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-2310] fix: Issue count alignment when states are collapsed in kanban layout #5559
Conversation
WalkthroughThe changes in the Changes
Possibly related PRs
Suggested labels
Poem
Tip New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/core/components/issues/issue-layouts/kanban/headers/group-by-card.tsx (2 hunks)
Additional comments not posted (2)
web/core/components/issues/issue-layouts/kanban/headers/group-by-card.tsx (2)
115-116
: Alignment logic appears correct.The conditional application of class names based on
verticalAlignPosition
is implemented correctly. This should ensure that the content is centered vertically when required.Please ensure that additional screenshots or testing confirms the visual alignment as intended.
127-127
: Padding adjustment logic is correct.The conditional application of padding classes based on
verticalAlignPosition
is implemented correctly. This change should refine the visual presentation by adjusting the spacing appropriately.Please ensure that additional screenshots or testing confirms the padding adjustment as intended.
Problem Statement
Issue count when kanban header were minimized was aligned to the right instead of being in the center.
Solution
Changed align items to center when minimized and to baseline when maximized.
Screenshots and Media
Before
After
References
[WEB-2310]
Summary by CodeRabbit