Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-2310] fix: Issue count alignment when states are collapsed in kanban layout #5559

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Jimmycutie
Copy link
Contributor

@Jimmycutie Jimmycutie commented Sep 9, 2024

Problem Statement

Issue count when kanban header were minimized was aligned to the right instead of being in the center.

Solution

Changed align items to center when minimized and to baseline when maximized.

Screenshots and Media

Before

image

After

image

References

[WEB-2310]

Summary by CodeRabbit

  • Improvements
    • Enhanced vertical alignment in the Header Group By Card component for better content presentation.
    • Adjusted padding for improved spacing based on vertical alignment settings, refining the overall layout.

@Jimmycutie Jimmycutie added 🐛bug Something isn't working 🌐frontend 🌐web Issues related to our web product labels Sep 9, 2024
@Jimmycutie Jimmycutie added this to the v0.23-dev milestone Sep 9, 2024
@Jimmycutie Jimmycutie self-assigned this Sep 9, 2024
Copy link
Contributor

coderabbitai bot commented Sep 9, 2024

Walkthrough

The changes in the HeaderGroupByCard component focus on enhancing the layout and alignment of its elements. Modifications include updates to class names that determine the display style based on the verticalAlignPosition prop, improving vertical alignment in column layouts. Additionally, padding adjustments for the count display are made to better manage spacing based on the vertical alignment state.

Changes

File Path Change Summary
web/core/components/issues/issue-layouts/kanban/headers/group-by-card.tsx Modifications to class names for layout adjustments and padding changes based on verticalAlignPosition.

Possibly related PRs

Suggested labels

🌟improvement

Poem

In the kanban's dance, elements align,
With padding and classes, they beautifully shine.
A hop and a skip, the layout's refined,
Vertical harmony, oh what a find!
So here’s to the changes, a joyful cheer,
For a card that now stands proud and clear! 🐇✨

Tip

New features

Walkthrough comment now includes:

  • Possibly related PRs: A list of potentially related PRs to help you recall past context.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

  • Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fe280b2 and 685de7f.

Files selected for processing (1)
  • web/core/components/issues/issue-layouts/kanban/headers/group-by-card.tsx (2 hunks)
Additional comments not posted (2)
web/core/components/issues/issue-layouts/kanban/headers/group-by-card.tsx (2)

115-116: Alignment logic appears correct.

The conditional application of class names based on verticalAlignPosition is implemented correctly. This should ensure that the content is centered vertically when required.

Please ensure that additional screenshots or testing confirms the visual alignment as intended.


127-127: Padding adjustment logic is correct.

The conditional application of padding classes based on verticalAlignPosition is implemented correctly. This change should refine the visual presentation by adjusting the spacing appropriately.

Please ensure that additional screenshots or testing confirms the padding adjustment as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend 🌐web Issues related to our web product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants