OSSM-3429: Fix a compiler error#230
Conversation
Recently CI saw errors like this:
```
bazel-out/k8-fastbuild/bin/external/org_llvm_releases_compiler_rt/_virtual_includes/fuzzed_data_provider/fuzzer/FuzzedDataProvider.h:194:38: error: no member named 'numeric_limits' in namespace 'std'
return ConsumeIntegralInRange(std::numeric_limits<T>::min(),
~~~~~^
```
Apparently this is due to a incompatibility between the `compiler-rt`
dependency and the clang version we use (14.0).
This is fixed by updating `compiler-rt` to match clang 14. Actually This commit
cherry-picks the relevant changes done in upstream a while ago: envoyproxy/envoy#21135
|
/retest |
|
I'm still not sure why this became an issue only now and not before. Another approach for this issue (and future issues) would stick with clang 12 which is the version upstream 1.22 uses. But this is not ideal since the product is built using clang 14. Hence we also use clang 14 in community CI, to catch errors like this before we attempt to perform a product build (i.e. too late). |
|
/test unit |
|
@yxun: No presubmit jobs available for maistra/envoy@maistra-2.3 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jwendell: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Incorporated in #234 |
Recently CI saw errors like this:
Apparently this is due to a incompatibility between the
compiler-rtdependency and the clang version we use (14.0).This is fixed by updating
compiler-rtto match clang 14. Actually This commit cherry-picks the relevant changes done in upstream a while ago: envoyproxy/envoy#21135