Skip to content

OSSM-3429: Fix a compiler error#230

Closed
jwendell wants to merge 1 commit intomaistra:maistra-2.3from
jwendell:OSSM-3429
Closed

OSSM-3429: Fix a compiler error#230
jwendell wants to merge 1 commit intomaistra:maistra-2.3from
jwendell:OSSM-3429

Conversation

@jwendell
Copy link
Member

Recently CI saw errors like this:

bazel-out/k8-fastbuild/bin/external/org_llvm_releases_compiler_rt/_virtual_includes/fuzzed_data_provider/fuzzer/FuzzedDataProvider.h:194:38: error: no member named 'numeric_limits' in namespace 'std'
  return ConsumeIntegralInRange(std::numeric_limits<T>::min(),
                                ~~~~~^

Apparently this is due to a incompatibility between the compiler-rt dependency and the clang version we use (14.0).

This is fixed by updating compiler-rt to match clang 14. Actually This commit cherry-picks the relevant changes done in upstream a while ago: envoyproxy/envoy#21135

Recently CI saw errors like this:
```
bazel-out/k8-fastbuild/bin/external/org_llvm_releases_compiler_rt/_virtual_includes/fuzzed_data_provider/fuzzer/FuzzedDataProvider.h:194:38: error: no member named 'numeric_limits' in namespace 'std'
  return ConsumeIntegralInRange(std::numeric_limits<T>::min(),
                                ~~~~~^
```

Apparently this is due to a incompatibility between the `compiler-rt`
dependency and the clang version we use (14.0).

This is fixed by updating `compiler-rt` to match clang 14. Actually This commit
cherry-picks the relevant changes done in upstream a while ago: envoyproxy/envoy#21135
@jwendell
Copy link
Member Author

/retest

@jwendell
Copy link
Member Author

I'm still not sure why this became an issue only now and not before.

Another approach for this issue (and future issues) would stick with clang 12 which is the version upstream 1.22 uses. But this is not ideal since the product is built using clang 14. Hence we also use clang 14 in community CI, to catch errors like this before we attempt to perform a product build (i.e. too late).

@yxun
Copy link
Member

yxun commented Feb 20, 2023

/test unit

@openshift-ci
Copy link

openshift-ci bot commented Feb 20, 2023

@yxun: No presubmit jobs available for maistra/envoy@maistra-2.3

Details

In response to this:

/test unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maistra-bot
Copy link

@jwendell: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
envoy-unit-2.3 bf597f3 link true /test unit
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell
Copy link
Member Author

jwendell commented Mar 1, 2023

Incorporated in #234

@jwendell jwendell closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants