Merged
Conversation
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Lizan Zhou <lizan@tetrate.io>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
keith
reviewed
May 5, 2022
Member
keith
left a comment
keith
left a comment
There was a problem hiding this comment.
nice! thanks for doing all the real work here!
keith
previously approved these changes
May 6, 2022
keith
approved these changes
May 6, 2022
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
Risk Level: Low Testing: CI Docs Changes: Added Release Notes: Added Platform Specific Features: Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Lizan Zhou <lizan@tetrate.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jun 10, 2022
Risk Level: Low Testing: CI Docs Changes: Added Release Notes: Added Platform Specific Features: Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: Ryan Northey <ryan@synca.io>
jwendell
added a commit
to jwendell/envoy-1
that referenced
this pull request
Feb 16, 2023
Recently CI saw errors like this:
```
bazel-out/k8-fastbuild/bin/external/org_llvm_releases_compiler_rt/_virtual_includes/fuzzed_data_provider/fuzzer/FuzzedDataProvider.h:194:38: error: no member named 'numeric_limits' in namespace 'std'
return ConsumeIntegralInRange(std::numeric_limits<T>::min(),
~~~~~^
```
Apparently this is due to a incompatibility between the `compiler-rt`
dependency and the clang version we use (14.0).
This is fixed by updating `compiler-rt` to match clang 14. Actually This commit
cherry-picks the relevant changes done in upstream a while ago: envoyproxy/envoy#21135
twghu
pushed a commit
to twghu/maistra-envoy
that referenced
this pull request
Feb 28, 2023
Recently CI saw errors like this:
```
bazel-out/k8-fastbuild/bin/external/org_llvm_releases_compiler_rt/_virtual_includes/fuzzed_data_provider/fuzzer/FuzzedDataProvider.h:194:38: error: no member named 'numeric_limits' in namespace 'std'
return ConsumeIntegralInRange(std::numeric_limits<T>::min(),
~~~~~^
```
Apparently this is due to a incompatibility between the `compiler-rt`
dependency and the clang version we use (14.0).
This is fixed by updating `compiler-rt` to match clang 14. Actually This commit
cherry-picks the relevant changes done in upstream a while ago: envoyproxy/envoy#21135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com
Signed-off-by: Lizan Zhou lizan@tetrate.io
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]