-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create @magic-sdk/react-native-bare
SDK
#401
Merged
Ariflo
merged 13 commits into
ariflo-sc-52891-rn-expo-split-master
from
ariflo-sc-52891-decouple-rn-and-expo
Dec 28, 2022
Merged
Create @magic-sdk/react-native-bare
SDK
#401
Ariflo
merged 13 commits into
ariflo-sc-52891-rn-expo-split-master
from
ariflo-sc-52891-decouple-rn-and-expo
Dec 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to Shortcut Story #52891: Decouple Expo from RN to support bare RN. |
04dcd0b
to
8d6a724
Compare
8d6a724
to
becfd2c
Compare
Ethella
reviewed
Dec 21, 2022
Ethella
reviewed
Dec 21, 2022
Ethella
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two NITs, Otherwise LGTM
9218a98
to
9c66054
Compare
9c66054
to
9801ee9
Compare
208a5de
to
9f7cf67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
This PR will effectively replace the current
@magic-sdk/react-native
SDK with a new one called@magic-sdk/react-native-bare
for our devs utilizing a non-expo "Bare" react native (RN) setup.✅ Fixed Issues
Will generally resolve issues for devs utilizing a Bare RN setup with our SDK
🚨 Test instructions
Probably best to utilize my MagicBareRNExample app to test this setup. You'll need to follow these steps to test locally:
1 -
git pull
to get the latest version of the repo.2 -
git checkout ariflo-sc-52891-decouple-rn-and-expo
.3 -
cd packages/@magic-sdk/react-native-bare
.4 - Manually update the dependencies for
@magic-sdk/commons
,@magic-sdk/provider
,@magic-sdk/types
to the following:5 - run
npm link
in the root ofreact-native-bare
.6 - run
npm ls -g --depth=0 --link=true
to check that your link is there and pointing to the correct location. Copy the name; for me it was@magic-sdk/[email protected]
.7 - navigate up to
magic-js
root and runyarn build
, choose thereact-native-bare
package.8 - Go to your local copy of the
MagicBareRNExample
app.9 - run
npm link @magic-sdk/[email protected] --save --force
in the root ofMagicBareRNExample
.10 - run
yarn
.Run the app in iOS or Android as you normally would with
yarn iOS
oryarn android
respectively.Major Change
The following tasks should be completed before this PR is merged:
@magic-sdk/commons
,@magic-sdk/provider
,@magic-sdk/types
to npmjs@magic-sdk/react-native-bare
SDK.@magic-sdk/react-native-expo
SDK.