Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create @magic-sdk/react-native-bare SDK #401

Merged

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Dec 13, 2022

📦 Pull Request

This PR will effectively replace the current @magic-sdk/react-native SDK with a new one called @magic-sdk/react-native-bare for our devs utilizing a non-expo "Bare" react native (RN) setup.

✅ Fixed Issues

Will generally resolve issues for devs utilizing a Bare RN setup with our SDK

🚨 Test instructions

Probably best to utilize my MagicBareRNExample app to test this setup. You'll need to follow these steps to test locally:

1 - git pull to get the latest version of the repo.
2 - git checkout ariflo-sc-52891-decouple-rn-and-expo.
3 - cd packages/@magic-sdk/react-native-bare.
4 - Manually update the dependencies for @magic-sdk/commons, @magic-sdk/provider, @magic-sdk/types to the following:

    "@magic-sdk/commons": "file:../commons",
    "@magic-sdk/provider": "file:../provider",
    "@magic-sdk/types": "file:../types",

5 - run npm link in the root of react-native-bare.
6 - run npm ls -g --depth=0 --link=true to check that your link is there and pointing to the correct location. Copy the name; for me it was @magic-sdk/[email protected].
7 - navigate up to magic-js root and run yarn build, choose the react-native-bare package.
8 - Go to your local copy of the MagicBareRNExample app.
9 - run npm link @magic-sdk/[email protected] --save --force in the root of MagicBareRNExample.
10 - run yarn.

Run the app in iOS or Android as you normally would with yarn iOS or yarn android respectively.

Major Change

The following tasks should be completed before this PR is merged:

  • Publish latest version of @magic-sdk/commons, @magic-sdk/provider, @magic-sdk/types to npmjs
  • Publish latest version (12.0.1) of @magic-sdk/react-native-bare SDK.
  • Publish latest version (12.0.1) of @magic-sdk/react-native-expo SDK.

@Ariflo Ariflo added ✨Feature Request major Increment the major version when merged labels Dec 13, 2022
@Ariflo Ariflo requested a review from Ethella December 13, 2022 21:38
@Ariflo Ariflo self-assigned this Dec 13, 2022
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #52891: Decouple Expo from RN to support bare RN.

@Ariflo Ariflo force-pushed the ariflo-sc-52891-decouple-rn-and-expo branch from 04dcd0b to 8d6a724 Compare December 13, 2022 22:01
@Ariflo Ariflo marked this pull request as draft December 18, 2022 18:08
@Ariflo Ariflo force-pushed the ariflo-sc-52891-decouple-rn-and-expo branch from 8d6a724 to becfd2c Compare December 21, 2022 17:44
@Ariflo Ariflo marked this pull request as ready for review December 21, 2022 17:45
Copy link
Member

@Ethella Ethella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two NITs, Otherwise LGTM

@Ariflo Ariflo removed the major Increment the major version when merged label Dec 21, 2022
@Ariflo Ariflo changed the base branch from master to ariflo-sc-52891-create-react-native-expo-package December 28, 2022 19:35
@Ariflo Ariflo changed the base branch from ariflo-sc-52891-create-react-native-expo-package to ariflo-sc-52891-rn-expo-split-master December 28, 2022 19:35
@Ariflo Ariflo force-pushed the ariflo-sc-52891-decouple-rn-and-expo branch from 9218a98 to 9c66054 Compare December 28, 2022 20:27
@Ariflo Ariflo force-pushed the ariflo-sc-52891-decouple-rn-and-expo branch from 9c66054 to 9801ee9 Compare December 28, 2022 20:43
@Ariflo Ariflo force-pushed the ariflo-sc-52891-decouple-rn-and-expo branch from 208a5de to 9f7cf67 Compare December 28, 2022 20:45
@Ariflo Ariflo merged commit d83d668 into ariflo-sc-52891-rn-expo-split-master Dec 28, 2022
@Ariflo Ariflo deleted the ariflo-sc-52891-decouple-rn-and-expo branch December 28, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does latest magic sdk for react native support bare RN workflow?
2 participants