Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does latest magic sdk for react native support bare RN workflow? #369

Closed
2 tasks done
ilyavf opened this issue Oct 5, 2022 · 3 comments · Fixed by #401 or #412
Closed
2 tasks done

Does latest magic sdk for react native support bare RN workflow? #369

ilyavf opened this issue Oct 5, 2022 · 3 comments · Fixed by #401 or #412
Labels
❓Question released This issue/pull request has been released.

Comments

@ilyavf
Copy link

ilyavf commented Oct 5, 2022

✅ Prerequisites

  • Did you perform a cursory search of open issues? Is this question already asked elsewhere?
  • Are you reporting to the correct repository (magic-sdk)?

❓ Question

On the readme for @magic-sdk/react-native it says that for the bare RN workflow we have to stay on version 8. And states that there will be a separate package for this case:

Since 9.0.0, @magic-sdk/react-native package drops the support of bare React Native. You may stay on ^8.0.0 to keep your bare RN app functional. We will release a new package to support bare-RN exclusively.

Is there such a package or is it on the roadmap?

🌎 Environment

Software Version(s)
@magic-sdk/react-native 8.2.1
Operating System React Native
@KevMac19
Copy link

KevMac19 commented Oct 8, 2022

@ilyavf I was facing the same issue in my existing running application .

I am able to solve that by adding expo-modules and updating package version.

  • Update package

     yarn add @magic-sdk/react-native
  • Install expo-modules

    npx install-expo-modules
  • Android changes

    • MainActivity.java

      package com.packagename;
      import expo.modules.ReactActivityDelegateWrapper;
    • MainApplication.java

       package com.packagename;
       import android.content.res.Configuration;
       import expo.modules.ApplicationLifecycleDispatcher;
       import expo.modules.ReactNativeHostWrapper;
  • iOS changes

    • AppDelegate.h
      #import <React/RCTBridgeDelegate.h>
      #import <UIKit/UIKit.h>
      
      #import <Expo/Expo.h>

@Ethella
Copy link
Member

Ethella commented Oct 13, 2022

It's currently on the road map. We'll announce in the thread when it's ready

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❓Question released This issue/pull request has been released.
Projects
None yet
4 participants