Range filter doesn't works with 0 values in admin #7103 #8776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes tests refactoring with more data cases.
|
@giacmir thank you for your contribution! Great job |
|
@giacmir Your fix has been delivered to the |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Mar 20, 2024
…pment [Bengals Team] Test Fixes and Automation Tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #7103 and refactors test for the
preparemethod of\Magento\Ui\Component\Filters\Type\Rangeclass.The old test wasn't actually checking anything. The test was still "green" even if in the meantime some methods changed name and with invalid data was passed to the dataprovider.
Now the test fails when something is wrong and there are some more data cases added to the dataprovider.