Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters can't filter ranged from 0 #7103

Closed
Corefix opened this issue Oct 20, 2016 · 2 comments
Closed

Filters can't filter ranged from 0 #7103

Corefix opened this issue Oct 20, 2016 · 2 comments
Assignees
@giacmir
Labels
bug report Component: Catalog Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@Corefix
Copy link
Contributor

Corefix commented Oct 20, 2016

Preconditions

  1. Community Version 2.1.2
  2. PHP 7.0.10
  3. Some products already in Magento with products with quantity 0 and products without

Steps to reproduce

  1. Go to Magento admin
  2. Go to Products > Catalog
  3. Select Filters
  4. Enter in Quantity from 0 to 0
  5. Press apply filters

Expected result

  1. I would expect to see all products with quantity of 0 to be displayed

Actual result

  1. All products are displayed

Comment

I have traced the problem back to the following class:
\Magento\Ui\Component\Filters\Type\Range

and the method:
applyFilterByType

I'm not sure why the condition in it is how it is, and thats why I didn't want to just do a PR fixing this.
@miakusha
Copy link
Contributor

Hi @Corefix , thanks for report
We've created internal ticket MAGETWO-60044 to address this issue.

@miakusha miakusha added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Component: Catalog labels Oct 25, 2016
@giacmir giacmir mentioned this issue Mar 3, 2017
Merged
magento-team pushed a commit that referenced this issue Mar 8, 2017
@ishakhsuvarov
MAGETWO-65488: [GitHub][PR] Range filter doesn't works with 0 values …
9cc2700 
…in admin #7103 #8776

 - Merge Pull Request #8776 from giacmir/magento2:rangefilter
magento-team added a commit that referenced this issue Mar 8, 2017
@magento-team
MAGETWO-65488: [GitHub][PR] Range filter doesn't works with 0 values …
2e012ab 
…in admin #7103 #8776
@okorshenko
Copy link
Contributor

@Corefix Thank you for reporting the issue
@giacmir thank you for fixing this issue in PR: #8776

@Corefix Corefix closed this as completed Mar 10, 2017
magento-engcom-team pushed a commit that referenced this issue Sep 29, 2021
@rganin
Merge pull request #7103 from magento-arcticfoxes/B2B-1873
202bd44 
B2B-1873: AWS S3: Get Cloud-Native-Testing WebAPI Test Builds to Work…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giacmir giacmir

Labels
bug report Component: Catalog Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@giacmir @veloraven @okorshenko @miakusha @Corefix