Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Unable to activate search form on phone #3770

Merged
merged 1 commit into from
Aug 22, 2016

Commits on Mar 14, 2016

  1. Bugfix: Unable to activate search form on phone

    This commit fixes the bug, when user was not able to activate search 
    form on mobile device after two sequential clicks on search icon (label).
    
    Bug description:
    
    1. First click (Field should show up): `focus` event is triggered and form is shown.
    2. Second click (Field should show off): `blur` and `focus` events are triggered
     2.1. Blur event set the timeout to hide the field.
     2.2. Focus event adds the `active` class to the field.
     2.3. Timeout function is called and field becomes hidden.
     2.4. Field is still has `focus` state, because user clicked on label again.
    3. **Third click (Field should show up): `blur` and `focus` events are triggered again,
        and field will not show up.**
    
    Proposed patch adds additional logic into 2.1:
    **Blur event will set the timeout to hide the field if the field already has `active` class name**
    vovayatsyuk committed Mar 14, 2016
    Configuration menu
    Copy the full SHA
    81fafc0 View commit details
    Browse the repository at this point in the history