Bugfix: Unable to activate search form on phone #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the bug, when user was not able to activate search
form on mobile device after two sequential clicks on search icon (label).
Bug description:
1. First click (Field should show up): `focus` event is triggered and form is shown.
2. Second click (Field should show off): `blur` and `focus` events are triggered
2.1. Blur event set the timeout to hide the field.
2.2. Focus event adds the `active` class to the field.
2.3. Timeout function is called and field becomes hidden.
2.4. Field is still has `focus` state, because user clicked on label again.
3. **Third click (Field should show up): `blur` and `focus` events are triggered again,
and field will not show up.**
Proposed patch adds additional logic into 2.1:
**Blur event will set the timeout to hide the field if the field already has `active` class name**
vkorotun
added
Issue: Ready for Work
mmansoor-magento
pushed a commit
that referenced
this pull request
Aug 22, 2016
Fixes for:
MAGETWO-56868 Cannot save a product with images for the second time
MAGETWO-54355 [Github][PR] Bugfix: Unable to activate search form on phone #3770
MAGETWO-54580 [Github][PR] added partial fix for issue #2617. #3688
MAGETWO-53808 [Github][PR] Fixed post var name for update attributes #4011
MAGETWO-55950 Automate Create new Email Template test
MAGETWO-56197 Write functional test for Account sharing settings availability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the bug, when user was not able to activate search
form on mobile device after two sequential clicks on search icon (label).
Bug description:
focusevent is triggered and form is shown.blurandfocusevents are triggered2.1. Blur event set the timeout to hide the field.
2.2. Focus event adds the
activeclass to the field.2.3. Timeout function is called,
activeclass name is removed and field becomes hidden.(Field is still in
focusstate)blurandfocusevents are triggered again,and field will not show up.
3.1 Blur event set the timeout to hide the field.
...
Proposed patch adds additional logic into 2.1 and 3.1:
Blur event will set the timeout to hide the field if the field already has
activeclass name