Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] The store logo is missing when using the Magento_blank theme #27497

Conversation

vasilii-b
Copy link

Description (*)

This PR fixes the store logo visibility on the storefront when using the Magento_blank theme for the store.

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. The store logo is missing when using the Magento_blank theme #27496 : The store logo is missing when using the Magento_blank theme

Manual testing scenarios (*)

Please check the original issue's description.

Result

Desktop Tablet Mobile
Result desktop Result tablet Result mobile

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2020

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 30, 2020
@VitaliyBoyko VitaliyBoyko self-assigned this Apr 1, 2020
@magento-engcom-team
Copy link
Contributor

Hi @VitaliyBoyko, thank you for the review.
ENGCOM-7253 has been created to process this Pull Request
✳️ @VitaliyBoyko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@VitaliyBoyko VitaliyBoyko added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Apr 2, 2020
@magento-engcom-team
Copy link
Contributor

Hi @VitaliyBoyko, thank you for the review.
ENGCOM-7253 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
desktop
Screenshot from 2020-04-03 11-22-56
mobile
Screenshot from 2020-04-03 11-23-16

After:
desktop
Screenshot from 2020-04-03 11-23-53
tablet
Screenshot from 2020-04-03 11-25-58
mobile
Screenshot from 2020-04-03 11-24-03

@magento-engcom-team magento-engcom-team merged commit 4b83b0d into magento:2.4-develop Apr 4, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2020

Hi @vasilii-b, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gwharton
Copy link
Contributor

An unintended consequence of this commit, is that all themes that inherit from luma or blank, now have a logo fixed width of 170 pixels :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Event: Global-Contribution-Day Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants