Logo is always 170 pixels wide, regardless of actual size #29721

gwharton · 2020-08-23T12:00:10Z

Preconditions (*)

2.4-develop

Steps to reproduce (*)

Login to Admin
Content -> Configuration -> Global -> Edit -> Header
Upload 800x300 example logo image (attached to issue)
Enter 800 in Logo Attribute Width
Enter 300 in Logo Attribute Height
Save Configuration
Clear cache
Go to frontend and inspect logo dimensions

Expected result (*)

Logo is 800 pixels wide

Actual result (*)

Logo is 170 pixels wide

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

Severity: S0 - Affects critical data or functionality and leaves users without workaround.
Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

The cause is this

magento2/app/design/frontend/Magento/blank/Magento_Theme/layout/default.xml

Lines 8 to 16 in 8b7d949

    
           <page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd"> 
        
               <body> 
        
                   <referenceBlock name="logo"> 
        
                       <arguments> 
        
                           <argument name="logo_width" xsi:type="number">170</argument> 
        
                       </arguments> 
        
                   </referenceBlock> 
        
               </body> 
        
           </page>

And was introduced here. #27497

m2-assistant · 2020-08-23T12:00:13Z

Hi @gwharton. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant · 2020-08-24T04:39:03Z

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
5. Add label Issue: Confirmed once verification is complete.
6. Make sure that automatic system confirms that report has been added to the backlog.

ajijshekh123 · 2020-08-25T06:02:05Z

@magento give me 2.4-develop instance

magento-engcom-team · 2020-08-25T06:02:10Z

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team · 2020-08-25T06:03:36Z

Hi @ajijshekh123, here is your Magento instance.
Admin access: https://i-29721-2-4-develop.instances.magento-community.engineering/admin_2352
Login: 58aa3b1b Password: 509815ad9f08
Instance will be terminated in up to 3 hours.

ajijshekh123 · 2020-08-25T06:19:06Z

Hello @gwharton,
I thought this is not an issue but this is a Magento feature.
As per your steps to be reproduced, actual result and expected result. I have reproduced on Magento 2.4 Instance.
PFA:
Admin:

Front end:

Thanks.

magento-engcom-team · 2020-08-25T06:21:09Z

@ajijshekh123 Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

magento-engcom-team · 2020-08-25T06:22:04Z

✅ Confirmed by @ajijshekh123
Thank you for verifying the issue. Based on the provided information internal tickets MC-36982 were created

Issue Available: @ajijshekh123, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

konarshankar07 · 2020-10-26T08:59:10Z

@klein0r ..
I agree with you but I have submitted the fix which will sort this issue. If you want to get more information then you check out my PR #29746

klein0r · 2020-10-26T09:03:33Z

I've seen that. But I've decided to create a default.xml for my shop, which is much easier to maintain than an additional patch file.

magentoexpert · 2021-01-24T16:23:16Z

This is not a fix for Magento 2.4.1 installed with composer. The new folder structure is completely different which includes /pub
The folder structure /app/design/frontend/Magento/ referred to above is empty and obsolete

denistrator · 2022-01-15T15:46:33Z

Easy workaround

<referenceBlock name="logo">
    <arguments>
        <argument name="logo_width" xsi:type="null"/>
    </arguments>
</referenceBlock>

Poovarasan-06 · 2023-08-21T13:27:54Z

@magento give me 2.4-develop instance

magento-deployment-service · 2023-08-21T13:27:57Z

Hi @Poovarasan-06. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2023-08-21T13:34:29Z

Hi @Poovarasan-06, here is your Magento Instance: https://567ec6c2acfe082eeb71761b7163972e.instances-prod.magento-community.engineering
Admin access: https://567ec6c2acfe082eeb71761b7163972e.instances-prod.magento-community.engineering/admin_0078
Login: f830acab
Password: 33238e24c566

Poovarasan-06 · 2023-08-22T04:54:32Z

@magento give me 2.4-develop instance

magento-deployment-service · 2023-08-22T04:54:35Z

Hi @Poovarasan-06. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2023-08-22T05:01:40Z

Hi @Poovarasan-06, here is your Magento Instance: https://567ec6c2acfe082eeb71761b7163972e.instances-prod.magento-community.engineering
Admin access: https://567ec6c2acfe082eeb71761b7163972e.instances-prod.magento-community.engineering/admin_ea6e
Login: 0786335f
Password: 7929f33891ac

Poovarasan-06 · 2023-08-22T08:21:01Z

@gwharton Hey, this issue is not reproducible in both testing instance and with my local setup.

isevchris · 2023-11-22T11:47:04Z

This appears to still be an issue with Magento 2.4.4-p6 at least, if your theme inherits from Magento Blank.

Essentially the logo image size gets loaded in from the following XML file:
./vendor/magento/theme-frontend-blank/Magento_Theme/layout/default.xml

If you override that file in your theme directory (./app/design/frontend); and set the xsi:type to null you can force it to load in the values from the database: core_config_data -> design/header/logo_width (or height).

    <referenceBlock name="logo">
        <arguments>
            <argument name="logo_width" xsi:type="null"></argument>
            <argument name="logo_height" xsi:type="null"></argument>
        </arguments>
    </referenceBlock>

engcom-Bravo · 2024-06-06T04:34:22Z

Hi @gwharton,

Thanks for your reporting and collaboration.

we have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Logo is 800 pixels wide

Hence We are closing this issue.

Thanks.

ghost added the Progress: ready for QA label Aug 23, 2020

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 23, 2020

ajijshekh123 self-assigned this Aug 24, 2020

ajijshekh123 added Area: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Aug 25, 2020

ghost unassigned ajijshekh123 Aug 25, 2020

magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 25, 2020

ghost added Progress: ready for dev and removed Progress: ready for QA labels Aug 25, 2020

ghost added Progress: ready for QA and removed Progress: ready for dev labels Aug 25, 2020

ajijshekh123 self-assigned this Aug 25, 2020

ajijshekh123 added Component: Image Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 25, 2020

ghost unassigned ajijshekh123 Aug 25, 2020

magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 25, 2020

magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020

m2-community-project bot added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Nov 13, 2020

mrtuvn mentioned this issue Nov 23, 2020

fix conflict for logo_height argument by default.xml #30370

Open

5 tasks

engcom-Alfa mentioned this issue Jan 25, 2021

Magento 2.4.1 logo size will not resize from admin #31816

Closed

1 task

m2-community-project bot unassigned konarshankar07 Dec 29, 2022

m2-community-project bot added Progress: ready for dev and removed Progress: PR in progress labels Dec 29, 2022

engcom-Bravo closed this as completed Jun 6, 2024

m2-community-project bot added Progress: done and removed Progress: ready for dev labels Jun 6, 2024

engcom-Hotel added this to Low Priority Backlog Aug 19, 2024

engcom-Hotel moved this to Done in Low Priority Backlog Aug 19, 2024

magento-ct-gh-projects-svc removed this from Low Priority Backlog Jan 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logo is always 170 pixels wide, regardless of actual size #29721

Logo is always 170 pixels wide, regardless of actual size #29721

gwharton commented Aug 23, 2020 •

edited

Loading

m2-assistant bot commented Aug 23, 2020

m2-assistant bot commented Aug 24, 2020

ajijshekh123 commented Aug 25, 2020

magento-engcom-team commented Aug 25, 2020

magento-engcom-team commented Aug 25, 2020

ajijshekh123 commented Aug 25, 2020

magento-engcom-team commented Aug 25, 2020

magento-engcom-team commented Aug 25, 2020

konarshankar07 commented Oct 26, 2020

klein0r commented Oct 26, 2020

magentoexpert commented Jan 24, 2021

denistrator commented Jan 15, 2022

Poovarasan-06 commented Aug 21, 2023

magento-deployment-service bot commented Aug 21, 2023

magento-deployment-service bot commented Aug 21, 2023

Poovarasan-06 commented Aug 22, 2023

magento-deployment-service bot commented Aug 22, 2023

magento-deployment-service bot commented Aug 22, 2023

Poovarasan-06 commented Aug 22, 2023

isevchris commented Nov 22, 2023

engcom-Bravo commented Jun 6, 2024

Logo is always 170 pixels wide, regardless of actual size #29721

Logo is always 170 pixels wide, regardless of actual size #29721

Comments

gwharton commented Aug 23, 2020 • edited Loading

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

m2-assistant bot commented Aug 23, 2020

m2-assistant bot commented Aug 24, 2020

ajijshekh123 commented Aug 25, 2020

magento-engcom-team commented Aug 25, 2020

magento-engcom-team commented Aug 25, 2020

ajijshekh123 commented Aug 25, 2020

magento-engcom-team commented Aug 25, 2020

magento-engcom-team commented Aug 25, 2020

konarshankar07 commented Oct 26, 2020

klein0r commented Oct 26, 2020

magentoexpert commented Jan 24, 2021

denistrator commented Jan 15, 2022

Poovarasan-06 commented Aug 21, 2023

magento-deployment-service bot commented Aug 21, 2023

magento-deployment-service bot commented Aug 21, 2023

Poovarasan-06 commented Aug 22, 2023

magento-deployment-service bot commented Aug 22, 2023

magento-deployment-service bot commented Aug 22, 2023

Poovarasan-06 commented Aug 22, 2023

isevchris commented Nov 22, 2023

engcom-Bravo commented Jun 6, 2024

gwharton commented Aug 23, 2020 •

edited

Loading