[Backport] Fixed magento text swatch switches product image even if attribute feature is disabled

[ravi-chandra3197]

Original Pull Request

#19184

Description (*)

Fixed magento text swatch switches product image even if attribute feature is disabled #16446

Fixed Issues (if relevant)

1. magento 2.2.2 text swatch switches product image even if attribute feature is disabled #16446: Fixed magento text swatch switches product image even if attribute feature is disabled

Manual testing scenarios (*)

N/A

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[VladimirZaets]

Hi @ravi-chandra3197, thanks for collaboration. Why the code in your PR is different from origin PR?

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5301 has been created to process this Pull Request

[engcom-Alfa]

Hi @ravi-chandra3197.

I've checked PR changes and I'm not sure about the correct behavior of the magento after fix

Manual testing scenario:

1. Create Text Swatch attribute "test" with "Update Product Preview Image" set to NO;
2. Create configurable product with some variations for "test";
3. Add image to configurable product;
4. Add image to associated simple products;
5. Go to category with this product on Storefront;

Actual result: ✔️ product preview image does not change

6. Go to product page:

Actual result: ✖️ Images for child products are not displayed

@ravi-chandra3197 Is it the correct behavior?

Thanks!

[ravi-chandra3197]

Hi @ravi-chandra3197.

I've checked PR changes and I'm not sure about the correct behavior of the magento after fix

Manual testing scenario:

1. Create Text Swatch attribute "test" with "Update Product Preview Image" set to NO;
2. Create configurable product with some variations for "test";
3. Add image to configurable product;
4. Add image to associated simple products;
5. Go to category with this product on Storefront;

Actual result: product preview image does not change

1. Go to product page:

Actual result: Images for child products are not displayed

@ravi-chandra3197 Is it the correct behavior?

Thanks!

Hello @engcom-Alfa
can you check this #19184 (comment)

[sivaschenko]

@ravi-chandra3197, to be honest, I think we should update the comment as this setting meant to work for all Magento pages, in my opinion. But I would like to confirm with @piotrekkaminski to be sure

[m2-assistant]

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-5427 has been created to process this Pull Request

[sivaschenko]

@engcom-Alfa the behaviour described in #22510 (comment) is ok in my opinion

[m2-assistant]

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.