#22510: Static test fix.

magento · Jul 12, 2019 · c5674e5 · c5674e5
1 parent 4e190ef
commit c5674e5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/code/Magento/Swatches/Block/Product/Renderer/Configurable.php b/app/code/Magento/Swatches/Block/Product/Renderer/Configurable.php
@@ -462,6 +462,7 @@ protected function getHtmlOutput()
 
     /**
      * @return string
+     * @SuppressWarnings(PHPMD.RequestAwareBlockMethod)
      */
     public function getMediaCallback()
     {

diff --git a/app/code/Magento/Swatches/view/frontend/web/js/swatch-renderer.js b/app/code/Magento/Swatches/view/frontend/web/js/swatch-renderer.js
@@ -745,7 +745,8 @@ define([
                 $wrapper = $this.parents('.' + $widget.options.classes.attributeOptionsWrapper),
                 $label = $parent.find('.' + $widget.options.classes.attributeSelectedOptionLabelClass),
                 attributeId = $parent.attr('attribute-id'),
-                $input = $parent.find('.' + $widget.options.classes.attributeInput);
+                $input = $parent.find('.' + $widget.options.classes.attributeInput),
+                checkAdditionalData = JSON.parse(this.options.jsonSwatchConfig[attributeId]['additional_data']);
 
             if ($widget.inProductList) {
                 $input = $widget.productForm.find(
@@ -785,9 +786,7 @@ define([
                     $widget.options.jsonConfig.optionPrices
                 ]);
 
-            var checkAdditionalData = JSON.parse(this.options.jsonSwatchConfig[attributeId]['additional_data']);
-
-             if (1 == checkAdditionalData['update_product_preview_image']) {
+            if (checkAdditionalData['update_product_preview_image'] === '1') {
                 $widget._loadMedia(eventName);
             }
             $input.trigger('change');
-Original file line number
+Diff line change
@@ Expand Up / @@ -462,6 +462,7 @@ protected function getHtmlOutput() @@
         /**
          * @return string
+         * @SuppressWarnings(PHPMD.RequestAwareBlockMethod)
          */
         public function getMediaCallback()
         {
@@ Expand Down @@