Skip to content

[backport] Product attribute option manager's existing option check fails #20958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nazar65 wants to merge 2 commits into from
Closed

[backport] Product attribute option manager's existing option check fails #20958

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d85f50
backport-fix-issue-20716
Nazar65 Feb 4, 2019
22cdce5
static-test-fic
Nazar65 Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions app/code/Magento/Catalog/Model/Product/Attribute/OptionManagement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

use Magento\Framework\Exception\InputException;

/**
* Option management model for product attribute.
*/
class OptionManagement implements \Magento\Catalog\Api\ProductAttributeOptionManagementInterface
{
/**
Expand All @@ -25,7 +28,7 @@ public function __construct(
}

/**
* {@inheritdoc}
* @inheritdoc
*/
public function getItems($attributeCode)
{
Expand All @@ -36,7 +39,7 @@ public function getItems($attributeCode)
}

/**
* {@inheritdoc}
* @inheritdoc
*/
public function add($attributeCode, $option)
{
Expand All @@ -47,7 +50,7 @@ public function add($attributeCode, $option)
/** @var \Magento\Eav\Api\Data\AttributeOptionInterface $attributeOption */
$attributeOption = $attributeOption->getLabel();
});
if (in_array($option->getLabel(), $currentOptions)) {
if (in_array($option->getLabel(), $currentOptions, true)) {
return false;
}
}
Expand All @@ -59,7 +62,7 @@ public function add($attributeCode, $option)
}

/**
* {@inheritdoc}
* @inheritdoc
*/
public function delete($attributeCode, $optionId)
{
Expand Down