Skip to content

[backport] Product attribute option manager's existing option check fails#20958

Closed
Nazar65 wants to merge 2 commits intomagento:2.2-developfrom
Nazar65:backport-issue-18246
Closed

[backport] Product attribute option manager's existing option check fails#20958
Nazar65 wants to merge 2 commits intomagento:2.2-developfrom
Nazar65:backport-issue-18246

Conversation

@Nazar65
Copy link
Copy Markdown
Member

@Nazar65 Nazar65 commented Feb 4, 2019

Original Pull Request

#19451

Description (*)

Product attribute option manager's existing option check fails
Added strict flag to in_array

Fixed Issues (if relevant)

  1. Product attribute option manager's existing option check fails #18246

Manual testing scenarios (*)

  1. Add attribute options by calling \Magento\Catalog\Model\Product\Attribute\OptionManagement::add
  2. Add attribute option that has admin scope value '01'.
  3. Add another option for same attribute that has admin scope value '1'.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Copy Markdown
Contributor

ihor-sviziev commented Feb 5, 2019

Hi @Nazar65,
Could you create PR with the same changes to 2.3-develop branch at first?
Thank you!


Update:
Ah, sorry, it's backport of fix that was already merged to 2.3-develop.

@ihor-sviziev ihor-sviziev self-assigned this Feb 5, 2019
@ihor-sviziev
Copy link
Copy Markdown
Contributor

ihor-sviziev commented Feb 5, 2019

Hi @Nazar65,
I double checked, PR that fixing this issue #19612 was already merged to 2.2-develop.

@ghost
Copy link
Copy Markdown

ghost commented Feb 5, 2019

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev
Copy link
Copy Markdown
Contributor

Duplicate of #19612

@ihor-sviziev ihor-sviziev marked this as a duplicate of #19612 Feb 5, 2019
@Nazar65
Copy link
Copy Markdown
Member Author

Nazar65 commented Feb 5, 2019

@ihor-sviziev ok thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants