Skip to content

magento/magento2:#19101 - API REST and Reserved Order Id#20208

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
saphaljha:2.2-develop-PR-port-19130
Jan 16, 2019
Merged

magento/magento2:#19101 - API REST and Reserved Order Id#20208
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
saphaljha:2.2-develop-PR-port-19130

Conversation

@saphaljha
Copy link
Contributor

@saphaljha saphaljha commented Jan 11, 2019

Pull Request ot 2.3-develop

#19130

  • Fixed issue "Can not update cart with a reserved order number like 000000651"

Description (*)

Fixed Issues (if relevant)

  1. API REST and Reserved Order Id #19101: API REST and Reserved Order Id

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

- Fixed issue "Can not update cart with a reserved order number like 000000651"
@magento-engcom-team
Copy link
Contributor

Hi @saphaljha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport of #19130.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-3839 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 16, 2019

Hi @saphaljha, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @saphaljha. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@vasilii-b
Copy link

@magento-engcom-team this a backport and is Award: bug fix and original PR is Cleanup ?! WHAT THE HELL ?!!
#19130

@saphaljha saphaljha deleted the 2.2-develop-PR-port-19130 branch January 24, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants