Skip to content

Comments

[Quote] API: Fixed issue "Can not update cart with a reserved order number like 000000651"#19130

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
vasilii-b:2.3-issue-19101
Nov 14, 2018
Merged

[Quote] API: Fixed issue "Can not update cart with a reserved order number like 000000651"#19130
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
vasilii-b:2.3-issue-19101

Conversation

@vasilii-b
Copy link

Description (*)

Full description in #19101

Fixed Issues (if relevant)

  1. API REST and Reserved Order Id #19101

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

- Fixed issue "Can not update cart with a reserved order number like 000000651"
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Quote labels Nov 9, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vasilii-b would be REALLY nice to cover such case with api-functional test.

@vasilii-b
Copy link
Author

Hey @orlangur,
you kinda force me to create functional test in the same PR ? 🤔
Also, it's very interesting situation with this PR - has label Accept and you @orlangur requesting changes. How to understand that ?

@orlangur
Copy link
Contributor

@vasilii-b,

you kinda force me to create functional test in the same PR ? 🤔

what surprises you here?

This PR didn't get a single approve yet, so, accept label is set by mistake.

@magento-engcom-team magento-engcom-team merged commit fe7b9ac into magento:2.3-develop Nov 14, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@vasilii-b
Copy link
Author

Hi @magento-engcom-team, can you please describe why the Cleanup label was added ? This PR kinda fixes a serious bug when working with REST API. This "cleanup" allows developers to use the API as needed :)
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup Component: Quote Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants