Skip to content

Fix: SalesQuoteSaveAfterObserver fails to update the checkout session quote id when applicable #19425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 1 commit into from
Dec 7, 2018
Merged

Fix: SalesQuoteSaveAfterObserver fails to update the checkout session quote id when applicable #19425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions app/code/Magento/Checkout/Observer/SalesQuoteSaveAfterObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

use Magento\Framework\Event\ObserverInterface;

/**
* Class SalesQuoteSaveAfterObserver
*/
class SalesQuoteSaveAfterObserver implements ObserverInterface
{
/**
Expand All @@ -24,15 +27,18 @@ public function __construct(\Magento\Checkout\Model\Session $checkoutSession)
}

/**
* Assign quote to session
*
* @param \Magento\Framework\Event\Observer $observer
* @return void
*/
public function execute(\Magento\Framework\Event\Observer $observer)
{
/* @var \Magento\Quote\Model\Quote $quote */
$quote = $observer->getEvent()->getQuote();
/* @var $quote \Magento\Quote\Model\Quote */

if ($quote->getIsCheckoutCart()) {
$this->checkoutSession->getQuoteId($quote->getId());
$this->checkoutSession->setQuoteId($quote->getId());
}
}
}
5 changes: 3 additions & 2 deletions app/code/Magento/Checkout/Test/Unit/Observer/SalesQuoteSaveAfterObserverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,14 @@ protected function setUp()

public function testSalesQuoteSaveAfter()
{
$quoteId = 7;
$observer = $this->createMock(\Magento\Framework\Event\Observer::class);
$observer->expects($this->once())->method('getEvent')->will(
$this->returnValue(new \Magento\Framework\DataObject(
['quote' => new \Magento\Framework\DataObject(['is_checkout_cart' => 1, 'id' => 7])]
['quote' => new \Magento\Framework\DataObject(['is_checkout_cart' => 1, 'id' => $quoteId])]
))
);
$this->checkoutSession->expects($this->once())->method('getQuoteId')->with(7);
$this->checkoutSession->expects($this->once())->method('setQuoteId')->with($quoteId);

$this->object->execute($observer);
}
Expand Down