Fix: SalesQuoteSaveAfterObserver fails to update the checkout session quote id when applicable

[dmytro-ch]

Description (*)

The checkout session quote id is not updated due to line 35 in \Magento\Checkout\Observer\SalesQuoteSaveAfterObserver which incorrectly calls $this->checkoutSession->getQuoteId($quote->getId());
In order to update the checkout session quote id, the setQuoteId method should be called.

Fixed Issues (if relevant)

1. \Magento\Checkout\Observer\SalesQuoteSaveAfterObserver fails to update the checkout session quote id when applicable #19424: "\Magento\Checkout\Observer\SalesQuoteSaveAfterObserver fails to update the checkout session quote id when applicable"

Manual testing scenarios (*)

1. During the guest checkout, session quote id should be set after dispatching the sales_quote_save_after event.
2. Verify that the guest checkout is working properly.

Affected functionality

1. Guest Checkout

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sivaschenko]

nice catch!

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-3578 has been created to process this Pull Request

[magento-engcom-team]

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.