back-port-pull-19024#19374
Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom Nov 27, 2018
Merged
Conversation
Back-port magento#19024 from 2.3 to 2.2
Contributor
|
Hi @agorbulin. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
rodrigowebjump
approved these changes
Nov 24, 2018
Member
|
Hi @agorbulin Thanks for your contribution. |
Contributor
|
Hi @rodrigowebjump, thank you for the review. |
Contributor
|
Hi @agorbulin. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back-port #19024 from 2.3 to 2.2
Description (*)
Fixed Issues (if relevant)
It's fix for the ticket
https://support.magento.com/hc/en-us/requests/105483
Manual testing scenarios (*)
export some product by CSV export, open CSV for edit
set field new_from_date = 11/3/20
set field new_to_date = 11/3/19 (less than previous)
import CSV
see validation error: 'Make sure new_to_date is later than or the same as new_from_date'
Contribution checklist (*)