Add-validation-new-from-date-less-than-new-to-date-in-SCV-product-import#19024
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Nov 22, 2018
Conversation
add validation for fields new_from_date and new_to_date to make sure field new_from_date < new_to_date to prevent future errors during saving updated product
Contributor
Contributor
|
Hi @agorbulin. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
sivaschenko
approved these changes
Nov 7, 2018
Contributor
|
Hi @sivaschenko, thank you for the review. |
Contributor
|
Hi @agorbulin. Thank you for your contribution. |
agorbulin
pushed a commit
to agorbulin/magento2
that referenced
this pull request
Nov 24, 2018
Back-port magento#19024 from 2.3 to 2.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add validation for fields new_from_date and new_to_date
to make sure field new_from_date < new_to_date during CSV product import
to prevent future error 'Make sure the To Date is later than or the same as the From Date.' during saving updated product in BO
Description ()
Added validation during CSV product import:
new_from_date field must be <= than new_to_date field,
because the same validation performed during product saving in BO
Fixed Issues ()
It's fix for the ticket
https://support.magento.com/hc/en-us/requests/105483
Manual testing scenarios (*)
Contribution checklist (*)