Skip to content

[Backport] Fix the issue: Content overlaps the close button #19263#19340

Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
gelanivishal:2.2-develop-PR-port-19264
Nov 23, 2018
Merged

[Backport] Fix the issue: Content overlaps the close button #19263#19340
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
gelanivishal:2.2-develop-PR-port-19264

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

@gelanivishal gelanivishal commented Nov 22, 2018

Original Pull Request

#19264

Description (*)

The confirmation popups are broken due to the reduced width.
Looks like the expected width is 50rem. This rule has been added by the following commit: 2f133c8
In this case, we just need to resolve the issue related to content overlapping the "close" button.

Fixed Issues (if relevant)

  1. Broken backend popup view #19263: Broken backend popup view

Manual testing scenarios (*)

Affected functionality: The confirmation popups in admin panel.

  1. Login to admin panel.
  2. Go to System -> Cache Management.
  3. Click "Flush Cache Storage".

Expected result

  1. Content does not overlap the "close" button. (including tablet and mobile view);

screen shot 2018-11-18 at 5 38 23 pm

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Nov 22, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 22, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3534 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants