Skip to content

Fix the issue: Content overlaps the "close" button#19264

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
dmytro-ch:fix/2.3-issue-19263-admin-confirmation-popup
Nov 22, 2018
Merged

Fix the issue: Content overlaps the "close" button#19264
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
dmytro-ch:fix/2.3-issue-19263-admin-confirmation-popup

Conversation

@dmytro-ch
Copy link
Copy Markdown
Contributor

Description (*)

The confirmation popups are broken due to the reduced width.
Looks like the expected width is 50rem. This rule has been added by the following commit: 2f133c8
In this case, we just need to resolve the issue related to content overlapping the "close" button.

Fixed Issues (if relevant)

  1. Broken backend popup view #19263: Broken backend popup view

Manual testing scenarios (*)

Affected functionality: The confirmation popups in admin panel.

  1. Login to admin panel.
  2. Go to System -> Cache Management.
  3. Click "Flush Cache Storage".

Expected result

  1. Content does not overlap the "close" button. (including tablet and mobile view);

screen shot 2018-11-18 at 5 38 23 pm

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch requested a review from rogyar November 18, 2018 15:38
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Area: Lib/Frontend labels Nov 18, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch dmytro-ch changed the title Fix the issue: Content overlaps the "close" button #19263 Fix the issue: Content overlaps the "close" button Nov 18, 2018
@rogyar
Copy link
Copy Markdown
Contributor

rogyar commented Nov 19, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rogyar, here is your Magento instance.
Admin access: http://34.228.235.121/i-19264-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar
Copy link
Copy Markdown
Contributor

rogyar commented Nov 19, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: http://34.228.235.121/pr-19264//admin
Login: admin Password: 123123q

@ishakhsuvarov
Copy link
Copy Markdown
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ishakhsuvarov. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ishakhsuvarov, here is your new Magento instance.
Admin access: https://pr-19264.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Lib/Frontend Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants